fix: nock.removeInterceptor can remove the wrong Intercept
#2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll add a proper test if you accept the general solution.
gr2m
reviewed
Jul 13, 2023
There was a problem hiding this comment.
change looks good, thank you for opening the PR. As long as no other tests are failing and you add a test case for this change, we are good to go. Bonus points if you could push the test changes first to show the CI is failing, and then push your fix to make it green again, that really helps to review pull requests more quickly
gr2m
changed the title
nock.removeInterceptor can remove the wrong Intercept
|
🎉 This PR is included in version 13.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you agree with the general solution, I'll add a proper test and fix the current tests.
Fix #2418