Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRU #723

Closed
Tracked by #215
renxida opened this issue Jun 4, 2024 · 5 comments
Closed
Tracked by #215

GRU #723

renxida opened this issue Jun 4, 2024 · 5 comments
Assignees

Comments

@renxida
Copy link
Contributor

renxida commented Jun 4, 2024

taking these because these are going to be similar to #315 (lstm)

@renxida renxida changed the title GRU GRU and RNN Jun 4, 2024
@renxida renxida self-assigned this Jun 4, 2024
@renxida renxida mentioned this issue Jun 4, 2024
Closed
@renxida
Copy link
Contributor Author

renxida commented Jun 4, 2024

rnn and gru should be doable with a refactoring & adding some helper functions in:

#315

@vivekkhandelwal1
Copy link
Contributor

@renxida, can you please create 2 separate issues? That way, it would be easy to track them.

@renxida
Copy link
Contributor Author

renxida commented Jun 4, 2024

@vivekkhandelwal1 gru and lstm are special cases of rnn, and i expect that if i modify my lstm code to support RNNs in general, the same pr would support GRU also

@vivekkhandelwal1
Copy link
Contributor

@vivekkhandelwal1 gru and lstm are special cases of rnn, and i expect that if i modify my lstm code to support RNNs in general, the same pr would support GRU also

That's fine. I'll create a PR that will add 4 ops but in order to track them I have created 4 different issues. I'm just saying it's easy to track each op with a different issue instead of having multiple ops in the same issue.

@renxida
Copy link
Contributor Author

renxida commented Jun 4, 2024

oh ok! gotcha. i was assuming that there should be a 1-1 correspondance between issues and PRs. Will create another issue.

@renxida renxida changed the title GRU and RNN GRU Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants