-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import ONNX model zoo programs to iree_tests #275
Comments
This sounds like a great idea. Can we add the zoo as a git submodule? Can iree_tests do post-processing? If so, I don't really see the point in using anything else for public model testing (especially CI jobs). |
Yep, or it can be referenced from another local directory like
My view on post-processing is that the core IREE tools just operate on directly represented inputs and outputs. The compiler's job is to correctly translate an input program into an executable -- I really want to draw a hard line there if at all possible, or else the full mess of machine learning frameworks leaks down layers of the stack. A test generator that runs offline can do whatever pre- and post-processing it wants to produce those inputs and outputs. Where that gets tricky is when the tests can be considered "passed" with different numerical results. I'm not sure if lower precision (e.g. quantized) models running through the compiler and runtime are expected to produce results that are different beyond traditional per-element floating point comparison thresholds. |
That scope makes sense to me. I've been looking into issues with numerics mismatches in quantized models, and sometimes its because a node like |
Moving this issue to iree-test-suites: iree-org/iree-test-suites#6 |
https://github.com/onnx/models, https://onnx.ai/models/
The
iree_tests/onnx/
test suite currently imports "node" tests fromonnx/backend/test/case/node
. There are also a few "model" tests thereonnx/backend/test/case/model
, but many more models exist at https://github.com/onnx/models.Import process:
The text was updated successfully, but these errors were encountered: