-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SD shortfin CI fails when apt is locked #407
Comments
Workflow history: https://github.com/nod-ai/SHARK-Platform/actions/workflows/ci-sdxl.yaml Text:
(screenshots aren't searchable of copy/paste-able ;P) |
Added a fix to #411, but this still will throw an error if we don't have those installed and cannot acquire the lock. May not be an issue for a while. output logs: |
Please keep changes small and send them as individual PRs. We shouldn't need to wait for a larger patch to be reviewed and landed to fix a broken CI build. Something is suspicious here about the runner environment. Basic dependency setup / installation shouldn't be a sticky source of failures. Might make sense to run these jobs in containers or limit what other code (if any) is running on these machines. |
Agree, will send up separate PR. Containers are probably a bit heavy for this, but as long as we have env/machine setup flexibility validated within reason, it might be the most robust solution. |
I'm specifically wondering if |
Should probably first check if cmake & ninja are installed & of the proper version before attempting to install. I don't think checking requires acquiring the apt lock.
The text was updated successfully, but these errors were encountered: