Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to package a project dependent on segfault-raub using esbuild #12

Closed
epessoa-i opened this issue Jun 10, 2024 · 2 comments
Closed

Comments

@epessoa-i
Copy link
Contributor

Hello,
Thank you very much for maintaining segfault-raub.

When running esbuild to compile a .cjs script prior to packaging my project, esbuild does not recognize the module as native and complains it can't find the module. Adding ".node" to the require call solves the issue.

To make your work easier, I'll go ahead and submit a pull request adding this.

@raub
Copy link
Member

raub commented Oct 29, 2024

Hello, thank you for the contribution! I will consider adding ".node" exts to all addon imports then.

@raub
Copy link
Member

raub commented Oct 31, 2024

Published as 3.0.1. Also, source link.

@raub raub closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants