Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build under Node v6.0.0 #89

Closed
RobertWHurst opened this issue Apr 27, 2016 · 10 comments
Closed

Does not build under Node v6.0.0 #89

RobertWHurst opened this issue Apr 27, 2016 · 10 comments

Comments

@RobertWHurst
Copy link

screen shot 2016-04-26 at 7 45 39 pm

Just updated to Node v6.0.0. It seems I can no longer install node-inspector because v8-profiler is failing to build against the new V8.

@njbraun
Copy link

njbraun commented Apr 27, 2016

+1

@evanlucas
Copy link

This should be fixable by bumping to the latest nan version.

@RobertWHurst
Copy link
Author

Should be fixed now that my PR has been merged :)

@RobertWHurst
Copy link
Author

@3y3 Can you do a release to NPM?

@3y3
Copy link
Member

3y3 commented Apr 27, 2016

In progress

@RobertWHurst
Copy link
Author

@3y3 🍻

@RobertWHurst
Copy link
Author

RobertWHurst commented Apr 27, 2016

@3y3 I've got a PR for node-inspector so let me know once you've published 😄

@3y3
Copy link
Member

3y3 commented Apr 27, 2016

I should also update v8-debug deps
v8-profiler will be published after this build https://ci.appveyor.com/project/3y3/v8-profiler

@RobertWHurst
Copy link
Author

@3y3 Okie dokie.

@3y3
Copy link
Member

3y3 commented Apr 27, 2016

@RobertWHurst ,v8-profiler 5.6.1 was published.
Thank you for fast fix!

(v8-debug is next in line)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants