Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support uncompressing symlink #31

Merged
merged 12 commits into from
Aug 24, 2023
Merged

feat: support uncompressing symlink #31

merged 12 commits into from
Aug 24, 2023

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Jul 26, 2019 •
edited by fengmk2
Loading

closes #58 #93

@atian25 atian25 requested a review from popomore July 26, 2019 14:06
@atian25 atian25 force-pushed the symlink branch 2 times, most recently from e9b37cc to 4bd7264 Compare July 26, 2019 14:07
@fengmk2
Copy link
Member

fengmk2 commented Jul 26, 2019

@atian25 ci 没过。

@atian25 atian25 force-pushed the symlink branch 3 times, most recently from 083a415 to e9b5b7b Compare July 26, 2019 16:28
@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7d605fe). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage          ?   39.77%           
=========================================
  Files             ?       19           
  Lines             ?      533           
  Branches          ?        0           
=========================================
  Hits              ?      212           
  Misses            ?      321           
  Partials          ?        0
Impacted Files Coverage Δ
lib/utils.js 58.4% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d605fe...e9b5b7b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 26, 2019 •
edited
Loading

Codecov Report

Merging #31 (72dbca9) into master (d17b1ed) will increase coverage by 11.91%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #31       +/-   ##
===========================================
+ Coverage   85.82%   97.74%   +11.91%     
===========================================
  Files          19       19               
  Lines        1009     1018        +9     
  Branches      221      271       +50     
===========================================
+ Hits          866      995      +129     
+ Misses        143       23      -120
Files Changed Coverage Δ
lib/utils.js 98.10% <100.00%> (+31.27%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atian25 atian25 force-pushed the symlink branch 4 times, most recently from fdb6ed1 to eab5e9a Compare July 26, 2019 17:11
@fengmk2
Copy link
Member

fengmk2 commented Aug 28, 2019

@atian25 ci 修一下？

@atian25
Copy link
Member Author

atian25 commented Aug 28, 2019

ci 文件权限那个有点奇怪，本地没问题，ci 的权限不一样

@fengmk2 fengmk2 mentioned this pull request Jul 11, 2022
Closed
Nadwey added a commit to Space-Eternity-3/SE3-Launcher that referenced this pull request Apr 28, 2023
@Nadwey
Fix unpacking symlinks
eefdcf5 
- Fix unpacking symlinks - compressing library didn't support symlinks, so I just forked it and took the code from here node-modules/compressing#31
- Implement GetNodeJsExecs
@fengmk2 fengmk2 mentioned this pull request May 11, 2023
Closed
@fengmk2 fengmk2 self-assigned this May 11, 2023
@fengmk2
Copy link
Member

fengmk2 commented May 11, 2023

我晚点 rebase 一下继续推进。

@ayushmanchhabra ayushmanchhabra mentioned this pull request Aug 23, 2023
Closed
3 tasks
@ayushmanchhabra
Copy link

@fengmk2 @atian25 I am interested in getting this merged. The module is used in nw-builder. Currently, it is not recognising symbolic links on decompression. This would help a ton!

@fengmk2
Copy link
Member

fengmk2 commented Aug 24, 2023

@ayushmanchhabra Sure, I will merge it in this week.

@fengmk2 fengmk2 merged commit d596d88 into master Aug 24, 2023
18 checks passed
@fengmk2 fengmk2 deleted the symlink branch August 24, 2023 03:59
fengmk2 pushed a commit that referenced this pull request Aug 24, 2023
@semantic-release-bot
Release 1.10.0
1112123 
[skip ci]

## [1.10.0](v1.9.1...v1.10.0) (2023-08-24)

### Features

* support uncompressing symlink ([#31](#31)) ([d596d88](d596d88))
This was referenced Aug 24, 2023
Closed
Closed
Closed
@zkrige
Copy link

zkrige commented Sep 4, 2023

While this looks like it should work, its still not processing symlinks properly on extract

@ayushmanchhabra ayushmanchhabra mentioned this pull request Oct 2, 2023
Closed
@atian25 atian25 added the sweep https://docs.sweep.dev/ label May 22, 2024
@BrightLin BrightLin mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

@popomore popomore Awaiting requested review from popomore

Assignees

@fengmk2 fengmk2

Labels
enhancement sweep https://docs.sweep.dev/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atian25 @fengmk2 @ayushmanchhabra @zkrige