Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build target up to ES2022 #439

Merged
merged 9 commits into from
Mar 25, 2023
Merged

feat: build target up to ES2022 #439

merged 9 commits into from
Mar 25, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Mar 25, 2023

use enforce "node:" prefix eslint rule

@fengmk2
feat: build target up to ES2022
b2f770b 
use enforce "node:" prefix eslint rule
fengmk2
fengmk2 commented Mar 25, 2023
View reviewed changes
tsconfig.json
@@ -17,7 +17,7 @@
"suppressImplicitAnyIndexErrors": true,
"suppressExcessPropertyErrors": true,
"forceConsistentCasingInFileNames": true,
"target": "ES2020",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

兼容性看起来没问题。

@fengmk2 fengmk2 requested a review from killagu March 25, 2023 08:05
@codecov
Copy link

codecov bot commented Mar 25, 2023 •
edited
Loading

Codecov Report

Merging #439 (d09aafe) into master (3e12703) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
- Coverage   99.67%   99.51%   -0.17%     
==========================================
  Files           8        8              
  Lines        1227     1227              
  Branches      234      235       +1     
==========================================
- Hits         1223     1221       -2     
- Misses          4        6       +2
Impacted Files Coverage Δ
src/HttpAgent.ts 100.00% <100.00%> (ø)
src/HttpClient.ts 99.51% <100.00%> (-0.33%) ⬇️
src/Request.ts 100.00% <100.00%> (ø)
src/Response.ts 100.00% <100.00%> (ø)
src/diagnosticsChannel.ts 100.00% <100.00%> (ø)
src/utils.ts 98.72% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Capability Access +/- Transitive Count Publisher
vitest@0.29.7 0.28.5...0.29.7 eval, filesystem, shell, environment +1/-55 oreanno
@vitest/coverage-c8@0.29.7 0.23.4...0.29.7 filesystem +2/-32 oreanno

fengmk2
fengmk2 commented Mar 25, 2023
View reviewed changes
.eslintrc
"extends": "eslint-config-egg/typescript",
"extends": [
"eslint-config-egg/typescript",
"eslint-config-egg/lib/rules/enforce-node-prefix"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs/node#37246

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 25, 2023
View reviewed changes
test/fixtures/socket_server.ts
@@ -19,11 +18,11 @@
return new Promise(resolve => {
unixSocketServer.listen(socketPath, () => {
resolve({
url: `http://localhost/`,
url: 'http://localhost/',

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "http://localhost/" is used as [authorization header](1).
@fengmk2 fengmk2 merged commit 95a51ce into master Mar 25, 2023
@fengmk2 fengmk2 deleted the enforce-node-prefix branch March 25, 2023 10:32
fengmk2 pushed a commit that referenced this pull request Mar 25, 2023
@semantic-release-bot
Release 3.13.0
e6c7e72 
[skip ci]

## [3.13.0](v3.12.0...v3.13.0) (2023-03-25)

### Features

* build target up to ES2022 ([#439](#439)) ([95a51ce](95a51ce))
@github-actions
Copy link

🎉 This PR is included in version 3.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killagu killagu Awaiting requested review from killagu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fengmk2