Skip to content

Don't repeat tests when they fail. #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jwerre opened this issue Nov 15, 2021 · 6 comments
Closed

Don't repeat tests when they fail. #68

jwerre opened this issue Nov 15, 2021 · 6 comments
Labels
good first issue ✅ Good for newcomers tests 🧪 Relates to tests
Milestone

Comments

@jwerre
Copy link
Contributor

jwerre commented Nov 15, 2021

Let's change this to 0... why repeat failed tests?

@jankapunkt
Copy link
Member

Yes you are right, fail early fail often

@jankapunkt jankapunkt added good first issue ✅ Good for newcomers tests 🧪 Relates to tests labels Nov 16, 2021
@jankapunkt
Copy link
Member

@jwerre did you leave the project? I just wanted to mention you in another PR and found, that you are not in the team list anymore 👀

@jwerre
Copy link
Contributor Author

jwerre commented Jan 18, 2022

Ya, sorry guys... I mentioned it in the Discord. I wish I had more time to work on this I'm pretty busy these days. :(

@jankapunkt
Copy link
Member

Ah I see thanks for all your contribution so far I think we already did a great move! There is one open PR #107 of yours, I would pick it up and finish if you are okay with it

@jwerre
Copy link
Contributor Author

jwerre commented Jan 18, 2022

Yes please do.

@jankapunkt jankapunkt added this to the v4.3 milestone Aug 25, 2022
@jankapunkt jankapunkt modified the milestones: v4.3, v4.4 Mar 21, 2023
@jorenvandeweyer
Copy link
Member

Already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue ✅ Good for newcomers tests 🧪 Relates to tests
Projects
None yet
Development

No branches or pull requests

3 participants