Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage key should be encoded #1

Open
zeroid opened this issue Nov 1, 2018 · 0 comments
Open

Storage key should be encoded #1

zeroid opened this issue Nov 1, 2018 · 0 comments

Comments

@zeroid
Copy link

zeroid commented Nov 1, 2018

As part of the filenameFor (solid/kvplus-files/src/store.js line 149) function the key should be encoded to replace any invalid characters that cannot be part of a filename, in particular characters that might form part of a URI ( :, /, ?, #).

The reason for my request is that it appears OpenId authentication/authorization with solid/node-solid-server requires the JWT aud property/client_id to be a URI. This is enforced by way of the solid/oidc-auth-manager filterAudience function (solid/oidc-auth-manager/src/oidc-manager.js line 441).

Attempting to register a client with a URI for the client_id (e.g. via https://solid.community/register) fails with a 500 error which I believe to be the result of the server attempting to store the client information in a KVPFileStore using a URI key.

Disclaimer: I have not debugged this and my assumption is based solely on my reading of the code but this would seem a reasonable enhancement to make regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant