Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement container deletion? #1402

Open
kjetilk opened this issue Feb 5, 2020 · 2 comments
Open

Implement container deletion? #1402

kjetilk opened this issue Feb 5, 2020 · 2 comments

Comments

@kjetilk
Copy link
Member

kjetilk commented Feb 5, 2020

I had the following problem today: I was writing teardown tests for PUT operations. Currently, NSS doesn't check if LDP interaction models are inconsistent with the type of resource actually created, so it ends up creating resources that should have been rejected with 409. That's a very small issue, it probably doesn't happen in the wild anyway, we just want to tighten it up for the future.

Since the teardown tests are supposed to reset the state of the pod to the state it was before running the tests, I need to delete these falsely created resources, but that actually ends up failing the teardown.

I see many ways to fix this on my side, but the simplest would be if NSS was brought to where rough consensus on DELETE stands now, because then, my tests could simply be spec compliant, which is kinda the goal anyway :-)

In solid/specification#41 we found that when deleting a container, the resources it contains should also be deleted if the user has permissions to do so, but it should not recurse and delete subdirectories, if those exist, it should fail.

So, I figured, perhaps I could ask you to do that?

@kjetilk
Copy link
Member Author

kjetilk commented Feb 6, 2020

I implemented one of my other solutions, but you are still welcome to consider it anyway :-)

@jaxoncreed
Copy link
Contributor

It's good that you found another solution. Given you found it, I won't prioritize this, but it should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants