Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a /view route that shows just the sketch result #32

Open
fdb opened this issue Feb 22, 2018 · 3 comments
Open

Add a /view route that shows just the sketch result #32

fdb opened this issue Feb 22, 2018 · 3 comments

Comments

@fdb
Copy link
Member

fdb commented Feb 22, 2018

Add a special route, either in editor.js or using firebase.json to just show the result of the sketch without the editor. This page should:

  • load the sketch from the Firebase REST API.
  • set the seed if specified in the URL (?seed=ABC)
  • render the script
  • show the output as HTML on the page
  • have minimal dependencies (ideally no dependency on firebase.js / editor.js)

This is needed to solve #16 .

@TanviKumar
Copy link
Contributor

I'd like to work on this! By render the script do you mean to say, show the code written and the output as well, like how the site looks now except its a view-only HTML page.

@fdb
Copy link
Member Author

fdb commented Feb 23, 2018

I've already started work on this — I'll make a PR soon. However, I'm still waiting a bit on support for HTTP get (See #34)

@fdb fdb mentioned this issue Feb 23, 2018
3 tasks
@fdb
Copy link
Member Author

fdb commented Feb 23, 2018

See PR #36 for a first stab at the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants