Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a RethinkDB Adapter #1

Open
MiguhRuiz opened this issue Jul 19, 2016 · 5 comments
Open

Create a RethinkDB Adapter #1

MiguhRuiz opened this issue Jul 19, 2016 · 5 comments
Assignees

Comments

@MiguhRuiz
Copy link
Member

@MiguhRuiz commented on Sun Jul 17 2016

I want to create a RethinkDB Adapter to use with fruit. Do I have to create it in my personal profile? Any specific conditions?


@Javascipt commented on Sun Jul 17 2016

Ok , I'm going to invite you into the organization, I'll create a the repo so that you can start working on it. All you need to know is that the unit tests should be the same as other adapters, at least most of the tests. I haven't tought much about conditions, but you are the first contributor, we can specify new confitions for other contributors.


@MiguhRuiz commented on Sun Jul 17 2016

Should I have to use the same test tools that you use? I usually use ava which is a new test runner. What about publication on NPM? I have seen that you've send the module into it but how can I send updates of it?


@Javascipt commented on Sun Jul 17 2016

It's ok if you would like to use ava. What is your npm username ?


@MiguhRuiz commented on Sun Jul 17 2016

Great, thanks! 😄

Link to my NPM profile


@Javascipt commented on Sun Jul 17 2016

You are now co-owner of the package at npmjs :

$ npm owner ls fruit-rethinkdb
javascript <Array.prototype@gmail.com>
miguhruiz <miguhruiz@gmail.com>

Enjoy :)

@MiguhRuiz
Copy link
Member Author

I was trying to add Circle CI to the project, but it doesn't want to allow me to do it :(

captura de pantalla 2016-07-19 10 56 35

What should I do? @Javascipt

@Javascipt
Copy link
Member

I think you're allowed now

@MiguhRuiz
Copy link
Member Author

Can you give me a version of the Fruit logo without the white background.

I think that I'll be a good idea to put it on this image:

@Javascipt
Copy link
Member

Nice idea, I'll try to make ne as I did for other adapter and I'll send it to you. 👍

@MiguhRuiz
Copy link
Member Author

Alright, thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants