Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Buffer constructor: random-fill in Node.js 8.0.0? #90

Closed
Trott opened this issue Mar 30, 2017 · 12 comments
Closed

Buffer constructor: random-fill in Node.js 8.0.0? #90

Trott opened this issue Mar 30, 2017 · 12 comments

Comments

@Trott
Copy link
Member

Trott commented Mar 30, 2017

@nodejs/ctc Next vote that was started in the CTC meeting. If you are not listed below (or if your vote has changed or been recorded incorrectly), please comment! Thanks!

Should we random-fill in Node.js 8.0.0?

YES: @addaleax, @cjihrig, @targos, @fhinkel

NO: @mscdex, @ChALkeR, @indutny, @jasnell, @MylesBorins, @shigeki, @misterdjules, @trevnorris, @rvagg, @thefourtheye

ABSTAIN: @Trott, @Fishrock123, @ofrobots, @evanlucas

MY VOTE DEPENDS ON WHETHER OR NOT WE BACKPORT AND/OR WHICH RELEASE LINES WE BACKPORT TO:

There is a separate issue for the question of whether we zero-fill. If both pass and there's not consensus over which one to do, we'll have another vote.

@indutny
Copy link
Member

indutny commented Mar 30, 2017

NO

@jasnell
Copy link
Member

jasnell commented Mar 30, 2017

No (my vote is for zero-fill in Node.js 8.0.0)

@MylesBorins
Copy link

what james said

@Fishrock123
Copy link

abstain (favor zero-fill)

@ofrobots
Copy link

Abstain (favour zero fill).

@evanlucas
Copy link

Abstain (favor zero fill)

@shigeki
Copy link

shigeki commented Mar 30, 2017

No

@misterdjules
Copy link

My vote is no.

@trevnorris
Copy link

nope

@rvagg
Copy link
Member

rvagg commented Mar 31, 2017

no

@addaleax
Copy link
Member

If I’m counting correctly this has 9 No votes and 4 abstentions, which means that this can be closed with “No” as the result.

@thefourtheye
Copy link

No - Zero Fill.

@Trott Trott removed the ctc-review label Apr 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests