Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport http: Eliminate ClientRequest capture by Agent socket listeners #247

Closed
drewfish opened this issue Sep 19, 2017 · 3 comments
Closed

Comments

@drewfish
Copy link

At Yahoo we have a custom branch with a few internal changes. We've also backported nodejs/node#10134. I see that it's labelled dont-land-on-v6.x since it doesn't land cleanly. However the code delta reduces heap usage so might be valuable for everyone.

Let me know if you'd like me to attempt a PR on v6.x-staging (or whatever makes sense).

@MylesBorins
Copy link
Contributor

@drewfish if you can make a backport PR we would 100% be open to landing it. Thanks.

@drewfish
Copy link
Author

nodejs/node#15500

@gibfahn
Copy link
Member

gibfahn commented Sep 22, 2017

@drewfish thanks for raising the PR. As a general principle if something hasn't been backported and you think it's worth having (makes life easier, fixes bugs etc), then it's just a question of someone being willing to raise the backport PR (and you or anyone else is welcome to backport it).

If it's semver-minor then Release have to review, but our basic question is "will this benefit anyone", so a comment in the original PR saying "this fixes an issue for us" is really helpful.

So let us know what else you have in your internal branch, hopefully we can get everything in that you guys need.

I'll close, as I think this is resolved, but as I said please do comment on other issues that you'd like backported.

@gibfahn gibfahn closed this as completed Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants