You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At Yahoo we have a custom branch with a few internal changes. We've also backported nodejs/node#10134. I see that it's labelled dont-land-on-v6.x since it doesn't land cleanly. However the code delta reduces heap usage so might be valuable for everyone.
Let me know if you'd like me to attempt a PR on v6.x-staging (or whatever makes sense).
The text was updated successfully, but these errors were encountered:
@drewfish thanks for raising the PR. As a general principle if something hasn't been backported and you think it's worth having (makes life easier, fixes bugs etc), then it's just a question of someone being willing to raise the backport PR (and you or anyone else is welcome to backport it).
If it's semver-minor then Release have to review, but our basic question is "will this benefit anyone", so a comment in the original PR saying "this fixes an issue for us" is really helpful.
So let us know what else you have in your internal branch, hopefully we can get everything in that you guys need.
I'll close, as I think this is resolved, but as I said please do comment on other issues that you'd like backported.
At Yahoo we have a custom branch with a few internal changes. We've also backported nodejs/node#10134. I see that it's labelled
dont-land-on-v6.x
since it doesn't land cleanly. However the code delta reduces heap usage so might be valuable for everyone.Let me know if you'd like me to attempt a PR on
v6.x-staging
(or whatever makes sense).The text was updated successfully, but these errors were encountered: