Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert of nodejs/node#55623 #1659

Open
Flarna opened this issue Nov 30, 2024 · 1 comment
Open

Revert of nodejs/node#55623 #1659

Flarna opened this issue Nov 30, 2024 · 1 comment

Comments

@Flarna
Copy link
Member

Flarna commented Nov 30, 2024

The PR nodejs/node#55623 caused a new issue: nodejs/node#56002.

nodejs/node#55623 landed already in 23.2.0 and to my understanding of contributor docs here a revert of a change already part of the releaes requires a TSC decission/discussion.

There is some history on above PR:

I don't have the needed windows know how to actually fix the problem on short notice.

Which direction should we go? Revert or wait a bit for a fixup?

@Flarna
Copy link
Member Author

Flarna commented Dec 2, 2024

PR to fix the issue instead of reverting: nodejs/node#56110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant