You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NAPI is currently missing support for property accessors, to enable C++ callbacks for getters and setters of properties on a wrapped object.
NAN supports this via the Nan::SetAccessor() function, which eventually calls v8::Object::SetAccessor() or v8::ObjectTemplate::SetAccessor(). NAPI currently has functions for getting and setting property values, but not for setting accessors.
From the data I collected, 5 of the top 12 native packages use one or both of those APIs: canvas, fibers, nodegit, sqlite3, zmq. The canvas module implements accessors for several properties like canvas.width, canvas.height, etc. The sqlite3 module only has a single getter for database.open.
The text was updated successfully, but these errors were encountered:
NAPI is currently missing support for property accessors, to enable C++ callbacks for getters and setters of properties on a wrapped object.
NAN supports this via the
Nan::SetAccessor()
function, which eventually callsv8::Object::SetAccessor()
orv8::ObjectTemplate::SetAccessor()
. NAPI currently has functions for getting and setting property values, but not for setting accessors.From the data I collected, 5 of the top 12 native packages use one or both of those APIs: canvas, fibers, nodegit, sqlite3, zmq. The canvas module implements accessors for several properties like
canvas.width
,canvas.height
, etc. The sqlite3 module only has a single getter fordatabase.open
.The text was updated successfully, but these errors were encountered: