Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ helper classes #53

Closed
jasongin opened this issue Jan 20, 2017 · 2 comments
Closed

C++ helper classes #53

jasongin opened this issue Jan 20, 2017 · 2 comments
Assignees
@jasongin
Milestone
Milestone 5

Comments

@jasongin
Copy link
Member

Code that is converted from V8's C++ classes to NAPI's C function  calls is often a little more verbose, e.g. napi_get_number_from_value(env, v) vs  v->NumberValue(). This could be cleaned up somewhat by adding low/zero-overhead C++ helper classes in NAPI, allowing for more V8 style interaction with objects, and therefore easier porting.
This was referenced Jan 20, 2017
Closed
Closed
@jasongin jasongin mentioned this issue Jan 31, 2017
Closed
@aruneshchandra aruneshchandra added this to the Milestone 5 milestone Feb 1, 2017
@jasongin jasongin mentioned this issue Feb 6, 2017
Closed
@jasongin
Copy link
Member Author

jasongin commented Feb 6, 2017

PR at #88

@aruneshchandra aruneshchandra mentioned this issue Feb 10, 2017
Closed
@aruneshchandra
Copy link
Contributor

This is landed already
nodejs/node-addon-api@fe1d9fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasongin jasongin

Labels
None yet
Projects
None yet
Milestone
Milestone 5
Development

No branches or pull requests
2 participants
@aruneshchandra @jasongin