Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable github pages & subdomain for Undici #590

Closed
2 tasks done
mcollina opened this issue Mar 9, 2021 · 22 comments
Closed
2 tasks done

Enable github pages & subdomain for Undici #590

mcollina opened this issue Mar 9, 2021 · 22 comments

Comments

@mcollina
Copy link
Member

mcollina commented Mar 9, 2021

@Ethan-Arrowood has developed a new website for Undici in nodejs/undici#585.

I would like to:

  • enable github pages
  • setup a domain name for the project

As of domains, here are a few options:

  • undici.nodejs.org
  • undici.nodejs.dev
  • undici.dev

The first two have the benefit of being official.

Are there any objections? What's the process for adding a DNS entry?

@targos
Copy link
Member

targos commented Mar 9, 2021

What's the process for adding a DNS entry?

Someone from @nodejs/build may know.

@rvagg
Copy link
Member

rvagg commented Mar 10, 2021

For nodejs.org, myself or @mhdawson usually handle these, tho there's some others with infra access that can. I guess just a signal that this is endorsed by (or at least has no objection from) the TSC is enough to make it move ahead, along with technical details of what it needs to point to. For nodejs.dev, that's something else entirely but maybe that'd be a good one to lean in to for this kind of thing? Is it expected that there's going to be more of these "official" style core packages? Maybe loading up nodejs.org isn't a great idea?

@mcollina
Copy link
Member Author

I have more or less the same questions as you @rvagg.

@mhdawson
Copy link
Member

+1

@mmarchini
Copy link
Contributor

cc @nodejs/community-committee

@mcollina
Copy link
Member Author

I have enabled github pages for the project at https://nodejs.github.io/undici/#/.

@mcollina
Copy link
Member Author

@mhdawson could you configure undici.nodejs.org to point to nodejs.github.io? I'll set up the rest.

@mhdawson
Copy link
Member

@mcollina done, it shows a 404, same as if I went to nodejs.github.io but I assume there is more setup on your end needed.

@targos
Copy link
Member

targos commented Mar 26, 2021

I set the custom domain at https://github.com/nodejs/undici/settings
GitHub says it's not possible to enable HTTPS but it's not clear why.

@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 26, 2021

@targos despite the error message https://undici.nodejs.org/ works as expected ¯_(ツ)_/¯

What cannot be enabled is "enforce https" which appears to be a domain record thing

@targos
Copy link
Member

targos commented Mar 27, 2021

So is it not possible to have automatic redirect from http to https for the nodejs.org domain ?

@bnb
Copy link
Contributor

bnb commented Mar 29, 2021

+1

@MylesBorins
Copy link
Contributor

@targos I'm unsure, would have to find out how dns was setup

@bnb
Copy link
Contributor

bnb commented Mar 29, 2021

(deleted a comment of my own that wasn't fully informed)

@MylesBorins
Copy link
Contributor

Quickly looking at the dns records on https://dnschecker.org/all-dns-records-of-domain.php it would appear that the DNS record points directly to cloudflare rather than pointing directly at GH-Pages. So we likely either need to enable the redirect on cloudflare (reasonably easy to do) or point DNS directly at GitHub

@mhdawson
Copy link
Member

Just let me know what you want added to cloudflare, if you can be specific what needs to be added (@MylesBorins sounded like you know what) that would be helpful.

@mhdawson
Copy link
Member

mhdawson commented Mar 29, 2021

This is what I'd added earlier:

CNAME | undici | nodejs.github.io | Auto | Proxied

@mcollina
Copy link
Member Author

I think there is something wrong in the DNS configuration.

https://docs.github.com/en/github/working-with-github-pages/troubleshooting-custom-domains-and-github-pages#https-errors

Apparently the DNS server is not configured correctly, it needs to be a CNAME to nodejs.github.io and not an A record.

@mcollina
Copy link
Member Author

Screenshot 2021-03-31 at 17 43 04

@mhdawson I think you need to remove proxied.

@mhdawson
Copy link
Member

@mcollina

What I see in the cloud flare/what I added was a CNAME pointing to nodejs.github.io. I've removed the proxied setting and we'll see if that does what's needed.

@MylesBorins
Copy link
Contributor

@mhdawson that worked http://undici.nodejs.org/ now automatically forwards to https://undici.nodejs.org/

@mcollina
Copy link
Member Author

mcollina commented Apr 1, 2021

It worked wonders! Amazing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants