-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable github pages & subdomain for Undici #590
Comments
Someone from @nodejs/build may know. |
For nodejs.org, myself or @mhdawson usually handle these, tho there's some others with infra access that can. I guess just a signal that this is endorsed by (or at least has no objection from) the TSC is enough to make it move ahead, along with technical details of what it needs to point to. For nodejs.dev, that's something else entirely but maybe that'd be a good one to lean in to for this kind of thing? Is it expected that there's going to be more of these "official" style core packages? Maybe loading up nodejs.org isn't a great idea? |
I have more or less the same questions as you @rvagg. |
+1 |
cc @nodejs/community-committee |
I have enabled github pages for the project at https://nodejs.github.io/undici/#/. |
@mhdawson could you configure |
@mcollina done, it shows a 404, same as if I went to nodejs.github.io but I assume there is more setup on your end needed. |
I set the custom domain at https://github.com/nodejs/undici/settings |
@targos despite the error message https://undici.nodejs.org/ works as expected ¯_(ツ)_/¯ What cannot be enabled is "enforce https" which appears to be a domain record thing |
So is it not possible to have automatic redirect from |
+1 |
@targos I'm unsure, would have to find out how dns was setup |
(deleted a comment of my own that wasn't fully informed) |
Quickly looking at the dns records on https://dnschecker.org/all-dns-records-of-domain.php it would appear that the DNS record points directly to cloudflare rather than pointing directly at GH-Pages. So we likely either need to enable the redirect on cloudflare (reasonably easy to do) or point DNS directly at GitHub |
Just let me know what you want added to cloudflare, if you can be specific what needs to be added (@MylesBorins sounded like you know what) that would be helpful. |
This is what I'd added earlier: CNAME | undici | nodejs.github.io | Auto | Proxied |
I think there is something wrong in the DNS configuration. Apparently the DNS server is not configured correctly, it needs to be a CNAME to |
@mhdawson I think you need to remove |
What I see in the cloud flare/what I added was a CNAME pointing to nodejs.github.io. I've removed the proxied setting and we'll see if that does what's needed. |
@mhdawson that worked http://undici.nodejs.org/ now automatically forwards to https://undici.nodejs.org/ |
It worked wonders! Amazing. |
@Ethan-Arrowood has developed a new website for Undici in nodejs/undici#585.
I would like to:
As of domains, here are a few options:
undici.nodejs.org
undici.nodejs.dev
undici.dev
The first two have the benefit of being official.
Are there any objections? What's the process for adding a DNS entry?
The text was updated successfully, but these errors were encountered: