Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PAT for blocklist import/export #672

Open
bnb opened this issue Mar 24, 2022 · 12 comments
Open

Create PAT for blocklist import/export #672

bnb opened this issue Mar 24, 2022 · 12 comments

Comments

@bnb
Copy link
Contributor

bnb commented Mar 24, 2022

For nodejs/.github#1 to be able to actually be run, it will need a PAT from an account that is an admin of both organizations - meaning, nodejs/ and pkgjs/. My assumption is that if @nodejs-github-bot isn't already an admin of pkgjs/, we should trivially be able to fix that but it'll still need to be done.

As such, I'm explicitly requesting a PAT with the admin:org scope be created for the nodejs/.github so the import/export tooling can be run. The admin:org scope is required by GitHub, and documentation for this requirement can be found here.

@bnb
Copy link
Contributor Author

bnb commented Mar 24, 2022

cc @nodejs/tsc

@bnb bnb added the tsc-agenda label Apr 7, 2022
@bnb
Copy link
Contributor Author

bnb commented Apr 7, 2022

added label since this has been open for two weeks with no review and I need +1s from the @nodejs/tsc 😅

@targos
Copy link
Member

targos commented Apr 7, 2022

+1

1 similar comment
@mhdawson
Copy link
Member

mhdawson commented Apr 7, 2022

+1

@BridgeAR
Copy link
Member

+1

@Trott
Copy link
Member

Trott commented Apr 18, 2022

I just tried to help @bnb by trying to create the token, but I don't have the authentication credentials for @nodejs-github-bot. Can someone else step in to do this? @nodejs/tsc @nodejs/github-bot @nodejs/build

@phillipj
Copy link
Member

Sure, I can create a token for the github-bot. Its credentials are part of the secrets repo too for future ref.

Do we have preferred ways of sharing such a token?

@bnb
Copy link
Contributor Author

bnb commented Apr 18, 2022

@phillipj if you'd want to just add it to the nodejs/.github repo as a GitHub Secret so you don't need to share it, that'd be sick. Ideally, it'd be named BLOCKLIST_TOKEN since that's what the current PR (nodejs/.github#1) uses, but I can change if needed :)

@phillipj
Copy link
Member

@bnb sounds good to me 👍🏻 I've already created the token, so if you provide me sufficient privileges in that repo, I'll create BLOCKLIST_TOKEN ASAP

@bnb
Copy link
Contributor Author

bnb commented Apr 18, 2022

AFAIK I only have the ability to provide that access via being an owner from the Moderators team, which I am not supposed to use for that. @Trott / @nodejs/tsc if one of y'all could maybe add @phillipj with the admin role to that repo and remove him when he done adding the token? 🙇🏻

@aduh95
Copy link
Contributor

aduh95 commented Apr 18, 2022

I've added @phillipj as Admin on nodejs/.github. Let me know when you no longer need it.

@phillipj
Copy link
Member

BLOCKLIST_TOKEN repository secret added.

@aduh95 feel free to remove my admin privileges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants