-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change main repo config to delete merged branches #701
Comments
+1 as long as there are no objections from @nodejs/releasers |
SGTM |
sgtm |
👍 |
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests should probably address any worry about deleting the staging branches as it looks like they are already protected branches |
+1 Let's try it, maybe after this weeks security releases are done? |
+1 as long as releasers agree |
+1 to also try it after this week's security releases. |
+1 after security release |
Security release is done so I've made this change. Thanks, everyone! |
I would like to check the box in the settings to delete merged branches. This will help with the PR branches created by GitHub Actions like the ones that update the AUTHORS file and the lint-md dependencies. Currently, if no one deletes the existing branch after merge, the next GitHub Actions run adds the new commit to the existing branch rather than creating a new one. We can probably adjust the various workflows to do that, but deleting merged PR branches seems like the sensible thing to do. I have this set up on all my personal repositories and have never had a problem. The only thing I wonder about here is if there is an edge case with any of our staging or release branches, I doubt it (and if there is, we can uncheck the box), but pinging @nodejs/.releasers to get their opinions.
@nodejs/tsc
The text was updated successfully, but these errors were encountered: