Skip to content

Add NPM_TOKEN of nodejs-foundation to nodejs/nodejs.org #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ovflowd opened this issue May 25, 2025 · 7 comments
Closed

Add NPM_TOKEN of nodejs-foundation to nodejs/nodejs.org #971

ovflowd opened this issue May 25, 2025 · 7 comments

Comments

@ovflowd
Copy link
Member

ovflowd commented May 25, 2025

Hey folks, following this issue which led to this pull request we need someone from the TSC to add on the repository settings (Secrets > GitHub Actions) a secret named NPM_TOKEN for the nodejs-foundation NPM account, so we can publish our @node-core packages

cc @nodejs/tsc @nodejs/build

@legendecas
Copy link
Member

NPM supports granular access tokens and it'd be good to limit the token scopes. For more information, check out https://docs.npmjs.com/about-access-tokens#about-granular-access-tokens.

Options:

Reading the thread on nodejs/nodejs.org#7776, I suppose that the packages to be published are:

  • @node-core/ui-components,
  • @node-core/website-i18n,
  • @node-core/rehype-shiki.

Are you good with a granular token on the specified packages?

@ovflowd
Copy link
Member Author

ovflowd commented May 26, 2025

Allow read/write access on listed packages,

Sounds good to me!

@node-core/ui-components,
@node-core/website-i18n,
@node-core/rehype-shiki.

For these packages. And if we ever need more, we can request more :)

@avivkeller can you confirm?

@avivkeller
Copy link
Member

Yes, those are the only ones we need right now

@legendecas
Copy link
Member

Added NPM_TOKEN repository GitHub action secret on https://github.com/nodejs/nodejs.org for the following packages:

The token has a required expiration date and it is set to May 27, 2026. Please let me know if it does not work.

@avivkeller
Copy link
Member

I'll merge our PR and test the token now.

@avivkeller
Copy link
Member

Token is good :-)

@ovflowd
Copy link
Member Author

ovflowd commented May 26, 2025

🎉 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants