Skip to content
This repository has been archived by the owner on Nov 28, 2020. It is now read-only.

Adding @puzpuzpuz to @nodejs/benchmarking #311

Closed
Trott opened this issue Apr 13, 2020 · 3 comments
Closed

Adding @puzpuzpuz to @nodejs/benchmarking #311

Trott opened this issue Apr 13, 2020 · 3 comments

Comments

@Trott
Copy link
Member

Trott commented Apr 13, 2020

New Collaborator @puzpuzpuz would like to be on the correct team for the benchmarks in Node.js core. It's not clear to me if @nodejs/benchmarking is the right group or not. Is it safe for me to go ahead and add them to @nodejs/benchmarking or does the Benchmarking Workgroup (is it still active?) have a different process?

/cc @addaleax

@Trott
Copy link
Member Author

Trott commented Apr 13, 2020

(By the way, @addaleax noticed that @mmarchini is on @nodejs/benchmarking but not listed in the README in this repo.)

@mmarchini
Copy link

The WG is being de-charteted (nodejs/TSC#822) which is why I didn't add my name to the readme. But the GitHub team will be kept for notifications, so +1 on adding @puzpuzpuz to it.

@Trott
Copy link
Member Author

Trott commented Apr 13, 2020

Ah, in that case, yeah, seems like the obvious thing to do is to add them. Done!

@Trott Trott closed this as completed Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants