Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss: upgrade required clang to 3.9 #1264

Closed
mmarchini opened this issue May 9, 2018 · 3 comments
Closed

Discuss: upgrade required clang to 3.9 #1264

mmarchini opened this issue May 9, 2018 · 3 comments

Comments

@mmarchini
Copy link
Contributor

(not sure if this issue should go here or in nodejs/node. I can move it there if needed)

One of the blocking issues to update V8 to 6.7 is related to a behavior change on clang after 3.9. There's an upstream CL (https://chromium-review.googlesource.com/c/v8/v8/+/1050666) to fix the issue for now, but I'm sure it will happen again. Upstream patches are fine as a short-term solution, but it won't take long before we start to hit bigger issues with clang version discrepancy. Besides, we're supporting a compiler version from 2014, while our oldest active release line (v6.x) was released on 2016.

I know we can't do such a huge requirement upgrade on our current release lines, but I believe we should start to plan on upgrading our minimum clang requirement to at least 3.9 (ideally 4.0) in a future semver-major (12, 13 maybe?).

Any thoughts on this?

@mmarchini
Copy link
Contributor Author

Another one: nodejs/node-v8#63

Seems like thread_local is only available on Xcode 8 and above.

@refack
Copy link
Contributor

refack commented Jun 13, 2018

I wanted to suggest to bump the OS version to 10.12 but it seems like 10.10 and 10.11 still have a significant market share 🤦‍♂️
image

@refack
Copy link
Contributor

refack commented Aug 10, 2018

AFAICT this can be closed (resolution was to retire 10.10 with it limited XCode for node11)

@refack refack closed this as completed Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants