Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to cover ninja build on windows #1288

Closed
refack opened this issue May 25, 2018 · 4 comments
Closed

need to cover ninja build on windows #1288

refack opened this issue May 25, 2018 · 4 comments

Comments

@refack
Copy link
Contributor

refack commented May 25, 2018

We don't cover building with ninja on Windows in CI. And so it broke with nodejs/node#17604.
Besides all the usual advantages of ninja, V8 is shifting towards ninja only build system, and in IMHO having a full node build based on ninja can reduce "impedance mismatch".

@bnoordhuis
Copy link
Member

I don't like the idea of widening the matrix for an obscure build option. The CI is already slow and flaky enough, it doesn't need more friction.

@refack
Copy link
Contributor Author

refack commented May 25, 2018

I don't like the idea of widening the matrix for an obscure build option.

How about a dedicated matrix just for the build related tools and options. We have several configure switches and Makefile targets that are not covered as well. I agree that they unnecessary friction WRT to actual code changes, hence to the regular node-test-commit matrix.

@bnoordhuis
Copy link
Member

I'd be okay with that.

@github-actions
Copy link

github-actions bot commented Mar 9, 2020

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Mar 9, 2020
@github-actions github-actions bot closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants