-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need to cover ninja build on windows #1288
Comments
I don't like the idea of widening the matrix for an obscure build option. The CI is already slow and flaky enough, it doesn't need more friction. |
How about a dedicated matrix just for the build related tools and options. We have several |
I'd be okay with that. |
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
We don't cover building with
ninja
on Windows in CI. And so it broke with nodejs/node#17604.Besides all the usual advantages of ninja, V8 is shifting towards ninja only build system, and in IMHO having a full node build based on ninja can reduce "impedance mismatch".
The text was updated successfully, but these errors were encountered: