You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We don't cover building with ninja on Windows in CI. And so it broke with nodejs/node#17604.
Besides all the usual advantages of ninja, V8 is shifting towards ninja only build system, and in IMHO having a full node build based on ninja can reduce "impedance mismatch".
The text was updated successfully, but these errors were encountered:
I don't like the idea of widening the matrix for an obscure build option.
How about a dedicated matrix just for the build related tools and options. We have several configure switches and Makefile targets that are not covered as well. I agree that they unnecessary friction WRT to actual code changes, hence to the regular node-test-commit matrix.
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
We don't cover building with
ninja
on Windows in CI. And so it broke with nodejs/node#17604.Besides all the usual advantages of ninja, V8 is shifting towards ninja only build system, and in IMHO having a full node build based on ninja can reduce "impedance mismatch".
The text was updated successfully, but these errors were encountered: