Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing to arm64 for investing issues in TLS error. #1567

Closed
shigeki opened this issue Nov 9, 2018 · 15 comments
Closed

Accessing to arm64 for investing issues in TLS error. #1567

shigeki opened this issue Nov 9, 2018 · 15 comments

Comments

@shigeki
Copy link

shigeki commented Nov 9, 2018

For further investigation of arm64 issues fo TLS error, I need to access and work on arm64 as commented in nodejs/node#23913 (comment).

CC @refack
Ref: nodejs/node#23913

@gdams
Copy link
Member

gdams commented Nov 9, 2018

I personally have no objections, can someone else from @nodejs/build approve as well?

@Trott
Copy link
Member

Trott commented Nov 9, 2018

+1

@refack
Copy link
Contributor

refack commented Nov 10, 2018

+1
Will get to it later.

@refack
Copy link
Contributor

refack commented Nov 11, 2018

Someone else already put the keys in 147.75.74.174

@shigeki
Copy link
Author

shigeki commented Nov 12, 2018

Oops, I've forgot the same issue of #842 in the Node-v8 and it occurs again in the current Node. My key is still remained. I will check if binaries as I did before.

@shigeki
Copy link
Author

shigeki commented Nov 13, 2018

I've checked asm binaries have no difference between Node-v10 and bare openssl-1.1.0i as below.

oot@test-packetnet-ubuntu1604-arm64-2:/var/tmp/shigeki/node# ls -l out/Release/obj.target/openssl/deps/openssl/config/archs/linux-aarch64/asm/crypto/*/*.o
-rw-r--r-- 1 root root   3576 Nov 13 06:50 out/Release/obj.target/openssl/deps/openssl/config/archs/linux-aarch64/asm/crypto/aes/aesv8-armx.o
-rw-r--r-- 1 root root   5344 Nov 13 06:50 out/Release/obj.target/openssl/deps/openssl/config/archs/linux-aarch64/asm/crypto/aes/vpaes-armv8.o
-rw-r--r-- 1 root root   5592 Nov 13 06:50 out/Release/obj.target/openssl/deps/openssl/config/archs/linux-aarch64/asm/crypto/bn/armv8-mont.o
-rw-r--r-- 1 root root   8152 Nov 13 06:50 out/Release/obj.target/openssl/deps/openssl/config/archs/linux-aarch64/asm/crypto/chacha/chacha-armv8.o
-rw-r--r-- 1 root root 162168 Nov 13 06:50 out/Release/obj.target/openssl/deps/openssl/config/archs/linux-aarch64/asm/crypto/ec/ecp_nistz256-armv8.o
-rw-r--r-- 1 root root   1520 Nov 13 06:50 out/Release/obj.target/openssl/deps/openssl/config/archs/linux-aarch64/asm/crypto/modes/ghashv8-armx.o
-rw-r--r-- 1 root root   3784 Nov 13 06:50 out/Release/obj.target/openssl/deps/openssl/config/archs/linux-aarch64/asm/crypto/poly1305/poly1305-armv8.o
-rw-r--r-- 1 root root   5712 Nov 13 06:50 out/Release/obj.target/openssl/deps/openssl/config/archs/linux-aarch64/asm/crypto/sha/sha1-armv8.o
-rw-r--r-- 1 root root   5544 Nov 13 06:50 out/Release/obj.target/openssl/deps/openssl/config/archs/linux-aarch64/asm/crypto/sha/sha256-armv8.o
-rw-r--r-- 1 root root   5296 Nov 13 06:50 out/Release/obj.target/openssl/deps/openssl/config/archs/linux-aarch64/asm/crypto/sha/sha512-armv8.o

root@test-packetnet-ubuntu1604-arm64-2:/var/tmp/shigeki/node# ls -l ../openssl-1.1.0i/crypto/*/*.o |grep arm
-rw-r--r-- 1 root root   3576 Nov 13 06:02 ../openssl-1.1.0i/crypto/aes/aesv8-armx.o
-rw-r--r-- 1 root root   5344 Nov 13 06:02 ../openssl-1.1.0i/crypto/aes/vpaes-armv8.o
-rw-r--r-- 1 root root   5592 Nov 13 06:02 ../openssl-1.1.0i/crypto/bn/armv8-mont.o
-rw-r--r-- 1 root root   8152 Nov 13 06:02 ../openssl-1.1.0i/crypto/chacha/chacha-armv8.o
-rw-r--r-- 1 root root 162168 Nov 13 06:02 ../openssl-1.1.0i/crypto/ec/ecp_nistz256-armv8.o
-rw-r--r-- 1 root root   1520 Nov 13 06:02 ../openssl-1.1.0i/crypto/modes/ghashv8-armx.o
-rw-r--r-- 1 root root   3784 Nov 13 06:02 ../openssl-1.1.0i/crypto/poly1305/poly1305-armv8.o
-rw-r--r-- 1 root root   5712 Nov 13 06:02 ../openssl-1.1.0i/crypto/sha/sha1-armv8.o
-rw-r--r-- 1 root root   5544 Nov 13 06:02 ../openssl-1.1.0i/crypto/sha/sha256-armv8.o
-rw-r--r-- 1 root root   5296 Nov 13 06:02 ../openssl-1.1.0i/crypto/sha/sha512-armv8.o

In above, they are build with Configure linux-aarch64 not config in order to omit -Wa,--noexecstack option that would be resolved in OpenSSL-1.1.1.

I had an only once test failure of TLS error during several CIi tests. I could not succeed to reproduce the TLS error after many retries of tests by hand and TLS connection scripts. It seems to have more tests to reproduce it.

@refack Could you move the arm64 machine of test-packetnet-ubuntu1604-arm64-2 out of CI for I'd like to run many CI tests and TLS connection tests for reproduction of TLS errors.

@refack
Copy link
Contributor

refack commented Nov 13, 2018

@refack Could you move the arm64 machine of test-packetnet-ubuntu1604-arm64-2 out of CI for I'd like to run many CI tests and TLS connection tests for reproduction of TLS errors.

Done.
https://ci.nodejs.org/computer/test-packetnet-ubuntu1604-arm64-2/

@shigeki
Copy link
Author

shigeki commented Nov 14, 2018

@refack Thanks. I'm going to run parallel tests with SSL debugging in /var/tmp/shigeki/shigeki_node/node/run_test_ci.sh for days to see if TLS errors are reproduced.

@refack
Copy link
Contributor

refack commented Nov 16, 2018

Sill working on this?

@shigeki
Copy link
Author

shigeki commented Nov 16, 2018

Yes, I can reproduce the issue but cannot identify its cause. It still need more time for me to investigate it.

@refack
Copy link
Contributor

refack commented Feb 7, 2019

I had an idea, to minimize interaction with CI please stop the Jenkins agent when doing manual testing and restarting it when done.

@mhdawson
Copy link
Member

mhdawson commented Feb 8, 2019

@shigeki still working on this now ?

@shigeki
Copy link
Author

shigeki commented Feb 8, 2019

@mhdawson Yes, I currently continue to run tests on the CI arm64 server to see if the issue is really resolved in the current master HEAD.

@mhdawson
Copy link
Member

k thanks.

@github-actions
Copy link

github-actions bot commented Mar 6, 2020

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is remove or a comment is made.

@github-actions github-actions bot added the stale label Mar 6, 2020
@github-actions github-actions bot closed this as completed Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants