Resume Build will sometimes (often?) test on the wrong branch/checkout 😱

[Trott]

So, something weird happens with Jenkins sometimes and it can cause incorrect test results and I have no idea what's going on.

But I think it might be kind of important?

Seems to happen with Resume Build CI runs only, or at least that's what I've noticed.

Here's one: https://ci.nodejs.org/job/node-test-pull-request/19458/

Parameters say the PR is nodejs/node#24922 (which is what I wanted) and it should be rebased against master, although Resume Builds don't rebase. But I would expect it to use the same code checkout from the previous run.

Instead, it's using some weird code checkout (maybe from the recent 10.x release or something?) with over 1000 commits showing up, but only once you drill into the re-run job. The main job is fine. See https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/19642/.

I don't even know if my change is in there! But it's running tests that were moved out of test/parallel and into test/benchmark weeks and weeks ago! Console is showing test/parallel/test-benchmark-*tests galore. There are none of those anymore.

So my code is not being tested correctly. It's being tested against something other than the code that I wrote it for.

Is this a known issue? Is there a way to avoid it?

[Trott]

Argh! Rookie error! My job hasn't started yet so the link is to a previous job. Never mind!