-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for core dumps on CI machines #196
Comments
I think that tests that are currently testing the This is already done in most tests of Moreover, I think core dump are not generated when a process aborts on Windows unless explicitly enabled, so we should be already OK on that platform. Thus, I think |
@misterdjules I think you are correct regarding windows not dumping with |
Is this still an issue? Or can it be closed? |
Seems to be a stale issue, closing for now. Please reopen if this is still needed. |
Related: nodejs/node#2776
This above PR verifies that the
--abort-on-uncaught-exception
flag works properly. If core dumps are enabled, this could begin filling up space quickly. Another option would be to change the location of core dumps to be inside the repo as they would be git cleaned on the next run.For now, the PR put the test into
test/abort
and the test will not be run on the CI servers until we can get this sorted out per IRC./cc @orangemocha @trevnorris
The text was updated successfully, but these errors were encountered: