Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for core dumps on CI machines #196

Closed
evanlucas opened this issue Sep 17, 2015 · 4 comments
Closed

Account for core dumps on CI machines #196

evanlucas opened this issue Sep 17, 2015 · 4 comments

Comments

@evanlucas
Copy link

Related: nodejs/node#2776

This above PR verifies that the --abort-on-uncaught-exception flag works properly. If core dumps are enabled, this could begin filling up space quickly. Another option would be to change the location of core dumps to be inside the repo as they would be git cleaned on the next run.

For now, the PR put the test into test/abort and the test will not be run on the CI servers until we can get this sorted out per IRC.

/cc @orangemocha @trevnorris

@misterdjules
Copy link
Contributor

I think that tests that are currently testing the --abort-on-uncaught-exception command line option don't use the core file that is produced as the result of the process aborting. Thus, disabling core file generation on the system on which the tests run is enough to not fill up space.

This is already done in most tests of --abort-on-uncaught-exception by using ulimit -c 0 on anything except Windows.

Moreover, I think core dump are not generated when a process aborts on Windows unless explicitly enabled, so we should be already OK on that platform.

Thus, I think test/abort/test-abort-uncaught-exception.js could implement the same mechanism and be moved to a folder that contains tests that are run by the CI platform.

@gibfahn
Copy link
Member

gibfahn commented Sep 15, 2016

@misterdjules I think you are correct regarding windows not dumping with --abort-on-uncaught-exception, when I last checked it was impossible to enable coredumps without using an external tool (see nodejs/node#7733).

@Trott
Copy link
Member

Trott commented May 23, 2018

Is this still an issue? Or can it be closed?

@maclover7
Copy link
Contributor

Seems to be a stale issue, closing for now. Please reopen if this is still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants