Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request access to benchmark CI #3118

Closed
anonrig opened this issue Dec 16, 2022 · 8 comments
Closed

Request access to benchmark CI #3118

anonrig opened this issue Dec 16, 2022 · 8 comments
Labels

Comments

@anonrig
Copy link
Member

anonrig commented Dec 16, 2022

Our benchmark CI runs on Ubuntu 16.04 and my pull request to add simdutf had a vague issue. I'd like to get access to the machine to understand the root cause of the issue.

Referencing nodejs/node#45803 (comment)

@sxa
Copy link
Member

sxa commented Dec 19, 2022

Added key to anonrig@92.51.196.115 (test-nearform_intel-ubuntu1604-x64-2) so you should be able to log in there, although @targos has marked it offline in jenkins for an upgrade so it's availability may not be clear :-)

@targos
Copy link
Member

targos commented Dec 19, 2022

This machine is longer running on Ubuntu 16.04. I started upgrading it to 18.04 yesterday (#3122)

@anonrig
Copy link
Member Author

anonrig commented Jan 29, 2023

I don't have access anymore. Would someone be able to add me back? @nodejs/build

@targos
Copy link
Member

targos commented Jan 30, 2023

What do you need access for?

@anonrig
Copy link
Member Author

anonrig commented Jan 30, 2023

@targos Run benchmarks specifically for URL parser, as well as understand the architecture/processor of the benchmark CI machine.

@targos
Copy link
Member

targos commented Jan 30, 2023

Run benchmarks specifically for URL parser

Can't you use the existing CI job(s) for that?

understand the architecture/processor of the benchmark CI machine

Hardware is described here: #791 (comment)

Note that the machine is currently offline, so that explains why you can't access it.

@anonrig
Copy link
Member Author

anonrig commented Feb 18, 2023

Can't you use the existing CI job(s) for that?

Unfortunately, going through the flow of CI jobs while trying to improve a certain part of Node is too time-consuming and having direct access to the resources (where the user does not have the necessary computing power to run the benchmark) will resolve the friction of contributing to performance-critical problems in Node.js

Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Dec 16, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants