Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granting Jenkins access to node-charkacore WG #334

Closed
orangemocha opened this issue Feb 18, 2016 · 6 comments
Closed

Granting Jenkins access to node-charkacore WG #334

orangemocha opened this issue Feb 18, 2016 · 6 comments

Comments

@orangemocha
Copy link

Ref: nodejs/node-chakracore#18
Ref: nodejs/node#4765 (comment)

@nodejs/jenkins-admins

Asking for permission to grant @nodejes/node-chakracore, who are the maintainers of https://github.com/nodejs/node-chakracore access to CI as we do for the nodejs/collaborators group.

@jbergstroem
Copy link
Member

Sounds good to me.

@rvagg
Copy link
Member

rvagg commented Feb 19, 2016

That's OK but it means you can't be as liberal when adding members to that team, it can't serve as a backdoor to Jenkins access. The Collaborators gating process is a handy way to make it difficult for malicious actors to get Jenkins access so you can't just go adding anyone to this new team because they put up their hand to help.

@jbergstroem
Copy link
Member

@rvagg I assumed that members of chakra-core would follow the same collaboration/contribution guidelines as node.js. Is this not the case?

@orangemocha
Copy link
Author

Duly noted, @rvagg . The plan is for the collaboration guidelines to be as close as possible to the guidelines for Node.js. Currently the team is comprised of existing Node.js collaborators + a few Microsoft employees who worked on the project before. I am comfortable that the current team meets the trust standards, and will keep this in mind before admitting any new collaborators.

On a related note, it would be in the interest of the build & testing efforts in Node.js to be able to grant Jenkins access to more individuals, so we should think of ways that we can sandbox their activities and mitigate the security concerns. #331 is on the wg-agenda for next Tuesday's meeting and it can serve as a starting point for this discussion.

@orangemocha
Copy link
Author

Moving forward with this (on Monday) unless there are any objections. The bar for joining the node-charkacore group will be kept in line with that for nodejs/collaborators.

@orangemocha
Copy link
Author

Done. The members of nodejs/node-chakracore now have the same access to Jenkins as do nodejs/collaborators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants