Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrating npm tests into CI #40

Closed
othiym23 opened this issue Feb 6, 2015 · 7 comments
Closed

integrating npm tests into CI #40

othiym23 opened this issue Feb 6, 2015 · 7 comments

Comments

@othiym23
Copy link

othiym23 commented Feb 6, 2015

I've been doing some work to make it so npm tests can be run as part of the overall build process for Node / io.js, preferably without too many side effects. It's kinda tough to mirror the behavior of a CI environment, so it would be great if somebody could either point me at a Vagrant image / Docker container, or get me access to a subset of the build environments so I have something to hammer on while I'm getting things sorted out.

also a windows ci environment would be great thanks

@rmg
Copy link

rmg commented Feb 6, 2015

@othiym23 the docker images being used for CI are in https://github.com/iojs/build-containers and think you should be able to just pull them down and run them against any iojs checkout.

@rmg
Copy link

rmg commented Feb 6, 2015

As in docker run -itv /local/path/to/iojs:/opt/iojs --rm iojs/build:iojs-ubuntu-trusty where /local/path/to/iojs is the iojs checkout you're modifying to run npm's tests as part of the core tests.

@othiym23
Copy link
Author

othiym23 commented Feb 6, 2015

Thanks, @rmg! Consider this a tracking issue for me to keep everyone up to date on my progress getting npm tests working properly with CI.

@rmg
Copy link

rmg commented Feb 6, 2015

Happy to help :-)

@rvagg
Copy link
Member

rvagg commented Feb 7, 2015

@othiym23 how about this instead: let me give you access to the io.js Jenkins and you can trigger builds across all the platforms by pointing it to your local (or npm) fork of io.js, then you can tinker all you want to get them right prior to a PR to io.js. I'm just about to add a bunch of new collaborators to Jenkins so I'll add you to the list while I'm at it.

@othiym23
Copy link
Author

@rvagg Sounds good. Right now I'm working on getting all of npm's tests passing on Travis under iojs and node 0.12; it turns out that there may be a bug in the new Keep-Alive support on http.Agent. Once I can get npm's tests all-green in that environment, I'll start working on getting the builds right in io.js's CI environment. Let me know if / where I need to send you an SSH key.

@jbergstroem
Copy link
Member

This nowadays lives in the citgm repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants