Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include shared library file in `binary/binary.tar.[xz,gz] in Win and arm tests #596

Closed
shigeki opened this issue Jan 18, 2017 · 3 comments
Closed

Comments

@shigeki
Copy link

shigeki commented Jan 18, 2017

nodejs/node#10865 has a test to use shared library files of node_test_engine built with gyp.

Currently the tests on Windows and arm were failed because the shared library files were lost in CI environment.
They can be solved by including Release\node_test_engine.dll in Windows tests and out/Release/libnode_test_engine.so in arm tests in binary/binary.tar.gz and binary/binary.tar.xz . Could someone help to do it?

@shigeki
Copy link
Author

shigeki commented Feb 3, 2017

Does anyone take care of this? It's no problem to move all files in out/Release.

@joaocgreis
Copy link
Member

Sorry @shigeki , I set up those jobs but was away for some weeks so I only noticed this now. I included those files in the binary package. Here is a test run: https://ci.nodejs.org/view/All/job/node-test-commit-windows-fanned/6870/ . For the arm-fanned job I added the code but did not test because the job is disabled (#611). Please reopen if there's any problem!

@shigeki
Copy link
Author

shigeki commented Feb 3, 2017

@joaocgreis No, problems. Many thanks for doing it. I'm going to submit a new ci job from now. I appreciate your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants