-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include shared library file in `binary/binary.tar.[xz,gz] in Win and arm tests #596
Comments
Does anyone take care of this? It's no problem to move all files in |
Sorry @shigeki , I set up those jobs but was away for some weeks so I only noticed this now. I included those files in the binary package. Here is a test run: https://ci.nodejs.org/view/All/job/node-test-commit-windows-fanned/6870/ . For the |
@joaocgreis No, problems. Many thanks for doing it. I'm going to submit a new ci job from now. I appreciate your work. |
nodejs/node#10865 has a test to use shared library files of
node_test_engine
built with gyp.Currently the tests on Windows and arm were failed because the shared library files were lost in CI environment.
They can be solved by including
Release\node_test_engine.dll
in Windows tests andout/Release/libnode_test_engine.so
in arm tests inbinary/binary.tar.gz
andbinary/binary.tar.xz
. Could someone help to do it?The text was updated successfully, but these errors were encountered: