-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Rebuild Plugin to Jenkins (ci.nodejs.org) #672
Comments
SGTM if it scratches an itch! |
Ping? I would use it quite often. |
Not quite sure what you mean, but when you press rebuild it pre-populates the parameters with whatever you set when you initially ran the build. That's kinda the whole point 😜 |
I mean fill the form but not submit it. e.g. for |
Yeah, that's how it works |
SGTM |
So this plugin is already installed, but just not enabled.
I'm not entirely sure why it's called I've enabled it, if anyone knows why it was disabled (and thinks it should continue to be disabled) please let me know. |
It won't actually be enabled until Jenkins is next restarted. I'm not sure how we normally do that, am I okay to just click the |
Restarted and it's there, see: RebuildRebuilds that job (like hitting Rebuild lastLike clicking on the last build and clicking Note that you get the chance to change parameters before you run. cc/ @nodejs/collaborators , I found this saves a lot of time when running jobs. |
@refack 😱 |
https://ci.nodejs.org/job/node-test-pull-request/9310/ - "Started by anonymous user" Although I'm not sure if it actually does anything. The sub-jobs are done near instantaneously but with reported running times in the tens of minutes, except for an ARM job which seems stuck on something. |
I think this is the (fixed in next release) bug report: https://issues.jenkins-ci.org/browse/JENKINS-36333 I don't think this has anything to do with the Rebuild Plugin, the EDIT: Looking at this feature request, which I think is the one that added Unfortunately we won't be able to update to the newer version of Jenkins until all our machines use Java 8. |
btw I installed this really early on but it was removed because of this security problem, somehow we've lost this institutional knowledge and I'm not really sure how we retain it across people changes. Interesting data point nonetheless. Sorry I missed this issue and the fact that it was back again! |
IMHO the only issue with this is DOS, and that might be mitigated by that you can only |
@rvagg which security problem, am I wrong in saying:
? |
We use the Rebuild plugin internally, and it's really helpful. It basically does a
Build now
and prepopulates the parameters with whatever they were set to in the job you are rebuilding. You can still change any you need to.Basically it saves a lot of typing when you're trying to fix a job which has lots of parameters.
cc/ @gdams
The text was updated successfully, but these errors were encountered: