ubuntu1204-clang341 has been disabled in CI

[MylesBorins]

Can we get this to skip so we don't have red builds?

[MylesBorins]

ping... this is quite annoying... seems like it is failign on v7 too

[gibfahn]

I can add something to the combination filter to skip, but do we know why it's failing on 4/6/7 but not master?

Example of failing build: https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1204-clang341-64/9384/console

/usr/bin/../lib/gcc/x86_64-linux-gnu/4.9/../../../../include/c++/4.9/cstddef:51:11: 
error: no member named 'max_align_t' in the global namespace
  using ::max_align_t;
        ~~^

EDIT: Some comments by @bnoordhuis and @MylesBorins which suggest this isn't a new thing, nodejs/node#12392 (comment) nodejs/node#12412 (comment) nodejs/node#12104 (comment)

[targos]

I think this is because of the upgrade to gcc 4.9: #650
It doesn't fail on master because this particular build is skipped.

[gibfahn]

Lots of people running into this elsewhere:
catchorg/Catch2#334
https://askubuntu.com/questions/523613/upgrade-to-gcc-4-9-broke-clang
http://stackoverflow.com/questions/23462950/clang-only-compiles-c11-program-using-boostformat-when-std-c11-option-i

Suggested fixes are "use libc++ instead of libstdc++" and "upgrade to clang 3.5". Not sure why it's intermittent, but it may be to do with ccache.

Given this, are there any objections to changing the existing master skip to include Node 4/6/7?

# clang is only supported in Node versions 7 and lower
MAJOR_VERSION=`cat src/node_version.h |grep "#define NODE_MAJOR_VERSION" | awk '{ print $3}'`
RUN_TESTS="RUN"
echo $SMARTOS_VERSION
if [[ "$nodes" =~ clang && ${MAJOR_VERSION} -gt "7" ]]; then # change to -gt "4"
  RUN_TESTS="DONT_RUN"
fi

Alternatively we could just remove ubuntu1204-clang341-64 from node-test-commit-linux.

[MylesBorins]

I have confirmed that the ubuntu1204-clang341 executor is skipped on master and failing on all release lines. I am disabling it from the main CI for now.

I'm unsure who originally set it up, but I've changed this issue to track the progress of adding this executor back to CI

/cc @nodejs/ctc @nodejs/build

[bnoordhuis]

For posterity: it was added (by Rod?) in response to nodejs/node#8323.

[jbergstroem]

I updated GCC on the box as a response to @targos on newer V8 requirements too. Then there's this.

[bnoordhuis]

I'll close this out, the buildbot has been removed.