Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: symlink to latest nightly #908

Closed
refack opened this issue Oct 10, 2017 · 5 comments
Closed

FR: symlink to latest nightly #908

refack opened this issue Oct 10, 2017 · 5 comments

Comments

@refack
Copy link
Contributor

refack commented Oct 10, 2017

(blahblahblah Windows blahblahblah 2.5 hour build) turns out I use the nightlies fairly frequently, but https://nodejs.org/download/nightly/ is unstructured, and even requires a tiny bit of parsing for automation. Could we create a symlink to the latest nightly?

@refack
Copy link
Contributor Author

refack commented Oct 10, 2017

P.S. Also a huge boon would be if I could grab the binary artifacts from node-compile-windows
/cc @joaocgreis

@joaocgreis
Copy link
Member

The compile jobs now archive artifacts - this will use some disk space in the CI host but should not be an issue.

Having the nightlies latest link might take some work, I suspect adding support to https://github.com/nodejs/nodejs-latest-linker and testing it well.

@rvagg
Copy link
Member

rvagg commented Oct 12, 2017

latest-linker uses simple sorting to figure out the latest. One reason I didn't add nightly symlinks in the first place is that it's technically possible to have them out of order, two with the same date but commits sorting differently. But that'd only happen if we had some weird extended compile-duration problem with them or they were manually triggered so I guess it's not a big deal.
The other reason is, latest what? There are usually multiple branches going on in there, do we just do the latest master?

@joaocgreis
Copy link
Member

possible to have them out of order, ... I guess it's not a big deal.

I agree.

The other reason is, latest what? There are usually multiple branches going on in there, do we just do the latest master?

What makes sense to me is having exactly the same as for releases. latest-v8.x would be the nightly generated from v8.x-staging, latest-v9.x would be master now and become v9.x-staging at some point. latest would always be master, we could even call it latest-master instead of just latest (if the code for distinguishing nightlies from releases is easy enough, else just ignore this for now).

@Trott
Copy link
Member

Trott commented Mar 22, 2019

Closing due to long period of inactivity. Feel free to re-open if this is a thing. I'm just trying to close stuff that has been ignored for sufficiently long that it seems likely it's not something we're going to get to.

@Trott Trott closed this as completed Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants