Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: escape markdown characters in user provided strings #122

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 16, 2022

aduh95 added a commit to aduh95/changelog-maker that referenced this pull request Jan 16, 2022
Empty commit to test escaping of markdown special characters in commit
group and author name.
aduh95 added a commit to aduh95/changelog-maker that referenced this pull request Jan 16, 2022
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good fix, in general, but that's a pretty picky markdown linter picking up the mid-word _ @ nodejs/node#41557

@rvagg rvagg merged commit 7c10a4e into nodejs:main Jan 17, 2022
rvagg added a commit that referenced this pull request Jan 17, 2022
rvagg added a commit that referenced this pull request Jan 17, 2022
@rvagg
Copy link
Member

rvagg commented Jan 17, 2022

merged but reverted in #123, github wasn't happy with an empty commit

github-actions bot pushed a commit that referenced this pull request Jan 17, 2022
## [2.8.0](v2.7.4...v2.8.0) (2022-01-17)

### Features

* escape markdown characters in user provided strings ([#122](#122)) ([aa0234f](aa0234f))
@github-actions
Copy link

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rvagg
Copy link
Member

rvagg commented Jan 17, 2022

nevermind, I had some time to get dirty on the commandline to retrieve the original commits and do a bit of rewriting, see f12fe58 & aa0234f and released in 2.8.0. Thanks @aduh95.

renawolford6 added a commit to renawolford6/changelog-maker-javascript that referenced this pull request Nov 9, 2022
## [2.8.0](nodejs/changelog-maker@v2.7.4...v2.8.0) (2022-01-17)

### Features

* escape markdown characters in user provided strings ([#122](nodejs/changelog-maker#122)) ([aa0234f](nodejs/changelog-maker@aa0234f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants