-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: escape markdown characters in user provided strings #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Jan 16, 2022
aduh95
added a commit
to aduh95/changelog-maker
that referenced
this pull request
Jan 16, 2022
aduh95
force-pushed
the
escape-group-and-author
branch
from
January 16, 2022 18:20
9fa44e2
to
57f2e41
Compare
Empty commit to test escaping of markdown special characters in commit group and author name.
aduh95
added a commit
to aduh95/changelog-maker
that referenced
this pull request
Jan 16, 2022
aduh95
force-pushed
the
escape-group-and-author
branch
from
January 16, 2022 18:24
57f2e41
to
30d7be3
Compare
aduh95
force-pushed
the
escape-group-and-author
branch
from
January 16, 2022 18:25
30d7be3
to
76bab97
Compare
rvagg
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good fix, in general, but that's a pretty picky markdown linter picking up the mid-word _
@ nodejs/node#41557
rvagg
added a commit
that referenced
this pull request
Jan 17, 2022
…)" This reverts commit 7c10a4e.
rvagg
added a commit
that referenced
this pull request
Jan 17, 2022
…)" This reverts commit 7c10a4e.
merged but reverted in #123, github wasn't happy with an empty commit |
rvagg
pushed a commit
that referenced
this pull request
Jan 17, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jan 17, 2022
## [2.8.0](v2.7.4...v2.8.0) (2022-01-17) ### Features * escape markdown characters in user provided strings ([#122](#122)) ([aa0234f](aa0234f))
🎉 This PR is included in version 2.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
renawolford6
added a commit
to renawolford6/changelog-maker-javascript
that referenced
this pull request
Nov 9, 2022
## [2.8.0](nodejs/changelog-maker@v2.7.4...v2.8.0) (2022-01-17) ### Features * escape markdown characters in user provided strings ([#122](nodejs/changelog-maker#122)) ([aa0234f](nodejs/changelog-maker@aa0234f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node#41557 (comment)