feat: --find-matching-prs for commits without PR-URL #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2022
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
renawolford6
added a commit
to renawolford6/changelog-maker-javascript
that referenced
this pull request
Nov 9, 2022
## [3.2.0](nodejs/changelog-maker@v3.1.0...v3.2.0) (2022-06-16) ### Features * --find-matching-prs for commits without PR-URL ([#130](nodejs/changelog-maker#130)) ([0aa7a2e](nodejs/changelog-maker@0aa7a2e)) ### Trivial Changes * update node versions in Actions matrix (& enable macos) ([#131](nodejs/changelog-maker#131)) ([2a87620](nodejs/changelog-maker@2a87620))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So .. I want to use
changelog-makerfor a project that doesn't usePR-URLmetadata, and also, it really is kind of annoying to have to put that in when GitHub knows what commit belongs to what PR and we now have a useful way to query for it.This introduces
--find-matching-prs=trueas an argument, then uses a GraphQL query to make a best guess as to what PR the commit belongs to and fills in the blanks for it. Because this is done before label collection it should also mean that we get to collect labels for commits that don't havePR-URLtoo, which is neat.(If someone wants to go back and fix up #73 now that this introduces a GraphQL pattern so we can use it to find labels, then that might be neat too).