Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures on master #518

Closed
MylesBorins opened this issue Dec 4, 2017 · 5 comments
Closed

Failures on master #518

MylesBorins opened this issue Dec 4, 2017 · 5 comments

Comments

@MylesBorins
Copy link
Contributor

Just finished doing an audit of citgm runs for 9.x and master

All 9.x failures are now accounted for and updated.

There are three modules failing on master for *nix that need to be looked into

@MylesBorins
Copy link
Contributor Author

@refack is digging into the failures on windows, which have a few additional failures not seen on other platforms

@refack
Copy link
Contributor

refack commented Dec 4, 2017

On Windows we have similar failures in:

  • eslint-v4.12.1

Unique:

  • iconv-v2.3.0 - digging further no repro

Infra:

  • lodash-v4.17.4
  • bson-v1.0.4
    Error: EPERM: operation not permitted, scandir ...
    

spawn-wrap related:

  • sax-v1.2.4
  • semver-v5.4.1
    module.js:561
       throw err;
       ^
    Error: Cannot find module 'C:\Users\Administrator\.node-spawn-wrap-4160-83374712ed52\node.EXE'
    

(https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1124/nodes=win-vs2015/testReport/)

@refack
Copy link
Contributor

refack commented Dec 4, 2017

iconv fail does not reproduce when run manually, so I assume it's also infra related (TTY streams in Jenkins are multiple manipulated java->MSYS->npm->node->iconv)

assert.js:42
   throw new errors.AssertionError({
   ^
 AssertionError [ERR_ASSERTION]: '�\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0001�' == '+AOc-x+AOc-'
     at Socket.<anonymous> (C:\Users\ADMINI~1\AppData\Local\Temp\1\6892bcce-9354-4db5-8fa0-eb2ab5cee83b\iconv\test\test-stream.js:65:14)
     at Socket.emit (events.js:126:13)
     at addChunk (_stream_readable.js:265:12)
     at readableAddChunk (_stream_readable.js:248:13)
     at Socket.Readable.push (_stream_readable.js:209:10)
     at TCP.onread (net.js:608:20)

/CC @bnoordhuis

@addaleax
Copy link
Member

addaleax commented Dec 5, 2017

I tried to look into eslintrm -rf node_modules && npm install did the trick for me, weirdly enough

gulp is due to natives being broken by nodejs/node#13295

@BridgeAR
Copy link
Member

This seems outdated and got superseded by #558

It should therefore be closed.

@al-k21 al-k21 closed this as completed Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants