Execution of local bin scripts fails on Windows

[targos]

To reproduce:

citgm bufferutil

It cannot find node-gyp-build. Probably another PATH issue...

[targos]

@bzoz any idea? I'm pretty sure process.env.PATH contains the correct node_modules/.bin directory (it's in the npm error log) so I don't know how to debug this further.

[richardlau]

Is it only bufferutil that fails (due to node-gyp-build (which is not the usual node-gyp used for native module compilation))?

[targos]

I think it's actually more than that. If there is an npm lifecycle script (install, postinstall, prepare) that calls a local dep, it fails.

[targos]

I'm going afk now but I will try to create a small module with such a case later to use in our tests

[targos]

See: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1688/nodes=win-vs2017/testReport/junit/(root)/citgm/vinyl_v2_2_0/

This really seems to be a general issue, not only during install.

[targos]

See https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1688/nodes=win-vs2017/#showFailuresLink for all modules failing because of this

[targos]

I made a simple bin script module here: https://github.com/targos/citgm-bin-script
I included it in the dependencies of another one here: https://github.com/targos/omg-i-pass-with-local-bin
This passes on Windows and Linux, so the problem is not with all bin scripts. I'm going to check what is different with mocha

[targos]

I'm lost...

This passes: citgm https://github.com/targos/omg-i-pass-with-local-bin/archive/master.tar.gz
This fails: citgm https://github.com/archiverjs/node-crc32-stream/archive/master.tar.gz

Both use mocha --reporter dot as npm test script.

[bzoz]

citgm https://github.com/targos/omg-i-pass-with-local-bin/archive/master.tar.gz fails for me ('citgm-bin-script' is not recognized as an internal or external command)

bufferutil also fails, but https://github.com/archiverjs/node-crc32-stream/archive/master.tar.gz works

[targos]

I didn't think this could get even more weird 😆

[bzoz]

And now (without changing anything in citgm) both citgm https://github.com/targos/omg-i-pass-with-local-bin/archive/master.tar.gz and citgm bufferutil works 🤷‍♂️. Maybe there was a bug in mocha or npm?

[targos]

I don't know what to think of it but you're right, everything works now...

[targos]

I can reproduce with these:

• citgm level
• citgm q

[MylesBorins]

extensive windows failures in this run --> https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1718/nodes=win-vs2017/testReport/

[targos]

/cc @refack maybe it rings a bell?

[BridgeAR]

This happens pretty frequently and the citgm output becomes pretty hard to read that way.

@refack PTAL

[refack]

Will do, first thing tomorrow.

[BridgeAR]

This is still unresolved. I do not have a Windows machine, so I can't look into this.

@refack do you still plan on pursuing this?

[targos]

looks like it's not reproducible anymore 🤷‍♂