Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle tags including numbers in prepare command #165

Merged
merged 6 commits into from
Sep 1, 2022
Merged

fix: handle tags including numbers in prepare command #165

merged 6 commits into from
Sep 1, 2022

Conversation

teppeis
Copy link
Contributor

@teppeis teppeis commented Aug 22, 2022

@aduh95
Copy link
Contributor

aduh95 commented Aug 23, 2022

Do you think we could add a test for that?

@teppeis
Copy link
Contributor Author

teppeis commented Aug 24, 2022

@aduh95 OK, I'll try.

It seems that CI tests are failing with high frequency even in the main branch.
Do you know the cause?

@teppeis
Copy link
Contributor Author

teppeis commented Sep 1, 2022

@aduh95 Thank you for #168.
After it is merged I'd like to add tests for this PR.
If that is going to take some time, please merge this PR first.

@aduh95
Copy link
Contributor

aduh95 commented Sep 1, 2022

@aduh95 Thank you for #168. After it is merged I'd like to add tests for this PR. If that is going to take some time, please merge this PR first.

Please don't wait for #168, the faster you add tests, the faster this can be merged, regardless of the flakiness of the CI :)

@teppeis
Copy link
Contributor Author

teppeis commented Sep 1, 2022

@aduh95 I've added a test.

aduh95
aduh95 reviewed Sep 1, 2022
View reviewed changes
tests/main.test.ts Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Sep 1, 2022
View reviewed changes
tests/main.test.ts Outdated Show resolved Hide resolved
@teppeis @aduh95
test: remove useless import
8e90b24 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 merged commit 5a0727b into nodejs:main Sep 1, 2022
@github-actions github-actions bot mentioned this pull request Sep 1, 2022
Merged
@teppeis teppeis deleted the fix-prepare-tag branch September 1, 2022 18:35
@teppeis teppeis mentioned this pull request Sep 3, 2022
Merged
Coryhotkiss
Coryhotkiss reviewed Dec 30, 2022
View reviewed changes
Copy link

@Coryhotkiss Coryhotkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want it all set up

Assylumware
Assylumware reviewed Dec 30, 2022
View reviewed changes
Copy link

@Assylumware Assylumware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want it all set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merceyz merceyz merceyz left review comments

@Assylumware Assylumware Assylumware left review comments

@Coryhotkiss Coryhotkiss Coryhotkiss left review comments

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

corepack prepare doesn't work for tags including a number
5 participants
@teppeis @aduh95 @merceyz @Assylumware @Coryhotkiss