Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update supported Node.js versions #258

Merged
merged 4 commits into from
May 19, 2023
Merged

chore: update supported Node.js versions #258

merged 4 commits into from
May 19, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 18, 2023

BREAKING CHANGE: remove support for Node.js 14.x

BREAKING CHANGE: remove support for Node.js 14.x
Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't cost much, if anything, to support Node.js v14.14.0 so could you document why support for it is dropped and why specifically v16.20.0 was chosen as the minimum?

If this is approved the tsconfig should be updated to ES2021 and the esbuild target changed as well.

"target": "ES2020"

"lib": ["ES2020"],

"build:bundle": "esbuild ./sources/_entryPoint.ts --bundle --platform=node --target=node14.14.0 --external:corepack --outfile='./dist/corepack.js' --resolve-extensions='.ts,.mjs,.js'",

@aduh95
Copy link
Contributor Author

aduh95 commented Apr 19, 2023

It doesn't cost much, if anything, to support Node.js v14.14.0

Pnpm v8 doesn't support Node.js v14.x anymore, so if we want to keep the pace, we have to drop it on CI, and if we drop it on CI, we should probably not document that we support it.

why specifically v16.20.0 was chosen as the minimum?

It's the latest v16 version, I don't have the bandwidth to test all the versions, using the latest seems easier and safer anyway.

README.md Outdated
@@ -15,7 +15,7 @@ use npm.

### Default Installs

Corepack is distributed by default with Node.js 14.19.0 and 16.9.0, but is
Corepack is distributed by default with all recent Node.js versions, but is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a specific version here because this is about the expectation of corepack cli being distributed with node in the current PATH.

Alternatively, we could link to the official docs that mention the versions in the first section:

Added in: v16.9.0, v14.19.0

@styfle
Copy link
Member

styfle commented Apr 19, 2023

It doesn't cost much, if anything, to support Node.js v14.14.0 so could you document why support for it is dropped

Another reason to drop node@14 is that it reaches EOL on 2023-04-30 in a couple weeks so newer versions of Corepack won't be distributed with future node@14 because there will be none after that date.

@aduh95 aduh95 requested review from merceyz and styfle April 21, 2023 23:04
@aduh95 aduh95 merged commit 74f679d into main May 19, 2023
@aduh95 aduh95 deleted the nodejs-versions branch May 19, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants