Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer of import-in-the-middle #634

Closed
Qard opened this issue Apr 30, 2024 · 11 comments
Closed

Transfer of import-in-the-middle #634

Qard opened this issue Apr 30, 2024 · 11 comments

Comments

@Qard
Copy link
Member

Qard commented Apr 30, 2024

We are proposing to donate the import-in-the-middle project to the Node.js organization to better open it up to shared collaboration with other APM vendors. There's an admin repo issue for this already, creating this one for our own reference and to add it to the working group agenda.

nodejs/admin#858

@RafaelGSS
Copy link
Member

+1

@mhdawson
Copy link
Member

mhdawson commented May 1, 2024

+1 from me

@bengl
Copy link
Member

bengl commented May 3, 2024

The current active contributor base (which we hope will grow!) for import-in-the-middle consists mainly of:

@bengl
@trentm
@jsumners-nr
@Qard

It would be good if these folks were involved in maintainership going forward. Under the assumption that this WG will assume maintainership of import-in-the-middle, should they all be members of (or seek membership in) this WG?

@jsumners-nr
Copy link

I am currently discussing with the Node team at New Relic to determine what we are up for (I don't see why we wouldn't want to be maintainers, but still need to go through the process).

@Qard
Copy link
Member Author

Qard commented May 6, 2024

No particular time commitment expected or anything like that, of course. Just want to make sure the keys to the project aren't held exclusively by Datadog. Other vendors sometimes encounter issues to be fixed and shouldn't be blocked on someone else landing and releasing those changes, especially given we're all depending on this project for our own products customers are paying for and expecting quick responses to issues on.

@bengl
Copy link
Member

bengl commented May 28, 2024

@nodejs/diagnostics please note the questions I asked in nodejs/admin#858. In particular, it would be great the first question (i.e. is maintainership going to be handled by this WG? or some new team perhaps?) can be answered. I'm happy to initiate the transfer after that.

@RafaelGSS
Copy link
Member

RafaelGSS commented May 28, 2024

We have discussed it a bit in today's meeting (#637) an it seems there are a significant number of contributors who would like to support the maintenance of this module as well as participate in other working group initiatives

Recording: https://www.youtube.com/watch?v=Q6snsixbu9o&ab_channel=node.js

@timfish
Copy link

timfish commented Jun 12, 2024

Is the transfer still in the works?

Having spent the last month living import-in-the-middle and helping with the roll-out at Sentry, I feel I mostly understand the challenges now and would love to be a maintainer!

@Qard
Copy link
Member Author

Qard commented Jun 12, 2024

It is, and we'd love to have your help! I'll check where we're at with the transfer tomorrow. 🙂

@Qard
Copy link
Member Author

Qard commented Jun 18, 2024

The transfer will be a major topic of the next WG call next Thursday. Please join us for the call, if you can! It is my hope that we can have the transfer done before then and the discussion can be focused on direction for the project, but there may be additional migration-related concerns that will need to be dealt with in the call too.

It is my goal to use the Diagnostics WG as a home for a few things we (Datadog) currently own but would prefer ownership by the Node.js project, so I would like to bring this working group back to a healthy state where we have a few active projects to work on. 😄

@AbhiPrasad
Copy link

First release of import-in-the-middle under the Node.js org: https://www.npmjs.com/package/import-in-the-middle/v/1.9.0 🎉

Thanks everyone for your help with the transfer! I think we can close this issue now.

@Qard Qard closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants