Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qemu to this docker image #512

Closed
dmednis opened this issue Sep 1, 2017 · 6 comments
Closed

Add qemu to this docker image #512

dmednis opened this issue Sep 1, 2017 · 6 comments
Labels

Comments

@dmednis
Copy link
Contributor

dmednis commented Sep 1, 2017

What are your thoughts on adding qemu to this image?
It would be useful for e.g. for cross-building arm docker images on x86 machines using multiarch/qemu-user-static:register .

@SimenB
Copy link
Member

SimenB commented Sep 1, 2017

How does it help if we bundle QEMU? Seems like a niche requirement, and it's pretty easy to add yourself of you want it (I think? Never tried, to be honest)

@SimenB SimenB added the question label Sep 1, 2017
@dmednis
Copy link
Contributor Author

dmednis commented Sep 1, 2017

For crossbuilding to work it is required to have QEMU in the base image. It would be more convenient if one would not have to rebuild the node base image with QEMU each time a new update came out.
On the other hand not everyone need QEMU in their image. Wanted to find out other peoples take on this.

@chorrell
Copy link
Contributor

chorrell commented Sep 1, 2017

👎 from me

As a general rule we try to avoid adding new packages to the images to keep the size down.

@yosifkit
Copy link
Contributor

yosifkit commented Sep 1, 2017

Just a note that you can run other architecture images using "Docker for Mac/Windows" which automatically uses qemu user mode emulation (nothing required to be installed in the container), but qemu often has problems:

@gibfahn
Copy link
Member

gibfahn commented Sep 11, 2017

For crossbuilding to work it is required to have QEMU in the base image. It would be more convenient if one would not have to rebuild the node base image with QEMU each time a new update came out.

Seems like the best solution would be for someone to create a new base image called node-qemu or whatever, and maybe try to get an automated travis build + push to Dockerhub whenever new node images come out.

@SimenB
Copy link
Member

SimenB commented Oct 24, 2017

Closing as we will not be making this change.

If someone:tm: does what @gibfahn suggest above me, we can link to it from our readme, though.

@SimenB SimenB closed this as completed Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants