Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

63.1 vs 63.2 and Reiwa support #35

Closed
srl295 opened this issue Apr 23, 2019 · 3 comments
Closed

63.1 vs 63.2 and Reiwa support #35

srl295 opened this issue Apr 23, 2019 · 3 comments
Assignees

Comments

@srl295
Copy link
Member

srl295 commented Apr 23, 2019

(ICU 64.2 supports the Reiwa era, as does 63.2 and others.)

Steps to reproduce: (I was not able to do step 2 exactly, so this is somewhat of a theory. Not sure how to run npm against a self-built Node yet.)

  1. configured/compiled Node with --with-intl=small-icu --with-icu-source=https://github.com/unicode-org/icu/releases/download/release-63-2/icu4c-63_2-src.tgz --download=all

  2. use npm install full-icu as directed. It will download the ICU 63 package, which will be 63.1 (not 63.2).

  3. The following are incorrect, and show that the 63.1 (not 63.2) data is being fetched:

$ ~/src/node/node --icu-data-dir=node_modules/icu4c-data/ -p "new Date('5/1/2019').toLocaleString('en-u-ca-japanese', {era: 'long'})"
5 1, 31 Heisei, 12:00:00 AM
$ ~/src/node/node --icu-data-dir=node_modules/icu4c-data/ -p "new Date('5/1/2019').toLocaleString('ja-u-ca-japanese', {era: 'long'})"
平成31年5月1日 0:00:00

(These should say 1 Reiwa / 令和元年5月1日 0:00:00) - note the era "令和"

@srl295 srl295 self-assigned this Apr 23, 2019
@srl295
Copy link
Member Author

srl295 commented Apr 23, 2019

Note, a workaround is to recompile node using --with-intl=full-icu. Don't use the full-icu package at all in that case. Node will have all data and will work properly.

@srl295
Copy link
Member Author

srl295 commented Apr 23, 2019

There's no issue for ICU4C 64.2, because the full-icu data is actually 64.2 not 64.1.

@srl295
Copy link
Member Author

srl295 commented Aug 3, 2020

closing as moot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant