Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up string_decoder #166

Closed
mcollina opened this issue Mar 1, 2018 · 5 comments
Closed

set up string_decoder #166

mcollina opened this issue Mar 1, 2018 · 5 comments

Comments

@mcollina
Copy link
Member

mcollina commented Mar 1, 2018

How can I get the webhook configured? I do not have access to the secret and all the folks that I pinged in @nodejs/build do not know about that specific step.

Here is the repo: https://github.com/nodejs/string_decoder.

@phillipj
Copy link
Member

phillipj commented Mar 1, 2018

There's two things needed in the following order;

  1. temporarily activate Travis CI to get the connection between github.com and Travis created
  2. custom webhook configured telling the @nodejs-github-bot to start polling Travis CI statuses continuously when new commits are pushed to any branch

Step 1 is usually the part that has been troublesome and caused lots of discussions over the years, as it requires us to allow Travis CI private access to the nodejs organisation for a short while. Those permissions may be revoked after the initial Travis CI webhook has been created.

The Travis CI connection has to be in place before thinking about setting up the custom webhook towards @nodejs-github-bot.

Since string_decoder is not listed in Travis CI's list of "connected repos", I assume step 1 has not been done for that repo yet. That's done by adding the "Travis CI" service in the repo settings -> Integrations & services:

screen shot 2018-03-01 at 22 30 48

It's been a while since I tried to activate Travis CI in a nodejs repo, but historically that flow ends in one having to request permissions from the nodejs org owners, to allow org wide private access. Whether or not the org owners are positive to that these days, I don't know to be honest, might be less of an issue these days now that the private nodejs org has been created.

As soon as we know that Travis CI connection is up-n-running, adding the custom bot webhook is a walk in the park. I'd suggest setting up the webhook as configured in the nodejs.org repo and ping me, @joyeecheung or @rvagg to get the webhook secret needed.

Does that make sense?

@mcollina
Copy link
Member Author

mcollina commented Mar 1, 2018

Step 1 was already done when I opened this.

schermata 2018-03-01 alle 22 48 49

I just need the secret (and it's probably better if someone else set it up).

@mcollina
Copy link
Member Author

mcollina commented Mar 1, 2018

I have been following this guide nodejs/admin#68. And I'm stuck in adding the secret (step 3 in the list).

@phillipj
Copy link
Member

phillipj commented Mar 1, 2018

Alright, I'll ping you in IRC with the secret, as I don't have enough permissions in the string_decoder repo to create it myself.

@mcollina
Copy link
Member Author

mcollina commented Mar 1, 2018

@phillipj awesome! thank you! I'll send the PR here tomorrow to add the repo to the bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants