-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set up string_decoder #166
Comments
There's two things needed in the following order;
Step 1 is usually the part that has been troublesome and caused lots of discussions over the years, as it requires us to allow Travis CI private access to the nodejs organisation for a short while. Those permissions may be revoked after the initial Travis CI webhook has been created. The Travis CI connection has to be in place before thinking about setting up the custom webhook towards @nodejs-github-bot. Since string_decoder is not listed in Travis CI's list of "connected repos", I assume step 1 has not been done for that repo yet. That's done by adding the "Travis CI" service in the repo settings -> Integrations & services: It's been a while since I tried to activate Travis CI in a nodejs repo, but historically that flow ends in one having to request permissions from the nodejs org owners, to allow org wide private access. Whether or not the org owners are positive to that these days, I don't know to be honest, might be less of an issue these days now that the private nodejs org has been created. As soon as we know that Travis CI connection is up-n-running, adding the custom bot webhook is a walk in the park. I'd suggest setting up the webhook as configured in the nodejs.org repo and ping me, @joyeecheung or @rvagg to get the webhook secret needed. Does that make sense? |
I have been following this guide nodejs/admin#68. And I'm stuck in adding the secret (step 3 in the list). |
Alright, I'll ping you in IRC with the secret, as I don't have enough permissions in the string_decoder repo to create it myself. |
@phillipj awesome! thank you! I'll send the PR here tomorrow to add the repo to the bot. |
How can I get the webhook configured? I do not have access to the secret and all the folks that I pinged in @nodejs/build do not know about that specific step.
Here is the repo: https://github.com/nodejs/string_decoder.
The text was updated successfully, but these errors were encountered: