Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor updates to pr and post Jenkins CI progress #5

Closed
jbergstroem opened this issue Apr 4, 2016 · 9 comments
Closed

Monitor updates to pr and post Jenkins CI progress #5

jbergstroem opened this issue Apr 4, 2016 · 9 comments

Comments

@jbergstroem
Copy link
Member

Background and further details here: nodejs/build#236

I'd be happy to chip in here.

@williamkapke
Copy link
Contributor

@phillipj Looking at @jbergstroem's work for the build team in that linked issue above, I see he/they are using the Github Status API. That seems like a cool way to go... maybe incorporate that in to the work you have in pollTravis?

@Fishrock123
Copy link
Contributor

Yeah we should probably push to the github status API. That way, it also displays at the merge button and you don't need to find the latest comment.

@Fishrock123
Copy link
Contributor

Related github module API: http://mikedeboer.github.io/node-github/#statuses, looking into it.

@phillipj
Copy link
Member

phillipj commented Apr 6, 2016

@williamkapke trying to use to status API sounds awesome! One step closer to mimic Travis completely 👯

@Fishrock123 Fishrock123 changed the title Monitor updates to pr and post CI progress Monitor updates to pr and post CI progress (Status API) Apr 8, 2016
@Fishrock123 Fishrock123 self-assigned this Apr 8, 2016
@Fishrock123 Fishrock123 changed the title Monitor updates to pr and post CI progress (Status API) Monitor updates to pr and post CI progress Apr 8, 2016
@Fishrock123
Copy link
Contributor

moving the status api discussion to #14

@Fishrock123 Fishrock123 changed the title Monitor updates to pr and post CI progress Monitor updates to pr and post Jenkins CI progress Apr 8, 2016
@Fishrock123 Fishrock123 removed their assignment Apr 10, 2016
@phillipj
Copy link
Member

@jbergstroem how would we know when to start polling? Could Jenkins do a HTTP requestagainst the bot, notifying there's a PR build that just started? Or should the bot listen for PR comments matching "CI: http://ci.nodejs.org/*"?

@jbergstroem
Copy link
Member Author

I owe a few of you a post -- sorry for the delay. I'm a bit backlogged at the moment; will get back to you shortly.

@phillipj
Copy link
Member

Seems the ../api/json endpoint would be perfect for polling build status. E.g. for nodejs/node#6342: https://ci.nodejs.org/job/node-test-pull-request/2363/api/json

@phillipj
Copy link
Member

phillipj commented May 6, 2017

Landed with #35

@phillipj phillipj closed this as completed May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants