-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify example for AsyncResource #1517
Comments
ping @nodejs/async_hooks |
+1 |
pinging @addaleax to see if a short description can be provided here. I can attempt, but cannot guarantee its correctness. |
Similarly,
|
I implemented a thread pool with worker_thread module , but is not clear how use AsyncResource on it . +1 |
@daprahamian - pls review nodejs/node#31601 and see if that helps you |
@gireeshpunathil yes I will review the PR today or tomorrow and will give a feedback on that , thanks !!! |
@gireeshpunathil I reviewed the PR , the example is clear and contains more details than expected ( error handling , wait a free worker, etc... ) :) . Thanks !!! |
@gireeshpunathil I looked it over, and the example looks good to me, and definitely clears up usage. Thanks! |
closing this as nodejs/node#31601 has landed that covers this. |
Hi there,
Can someone clarify the purpose of the new
AsyncResource
class? The example provided doesn't seem to show why it is beneficial.Thanks,
Dan
The text was updated successfully, but these errors were encountered: