Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if flag is in progress #75

Closed
pannous opened this issue Jan 11, 2016 · 4 comments
Closed

Warn if flag is in progress #75

pannous opened this issue Jan 11, 2016 · 4 comments

Comments

@pannous
Copy link

pannous commented Jan 11, 2016

(probably too many) users run into errors like
#31
nodejs/node#2760
etc

Please output warnings when encountering those flags!

node --harmony_modules

import { square, diag } from 'lib';
...
SyntaxError: Unexpected token import

@Knighton910
Copy link
Contributor

Hey at @pannous, did you have any luck with this so far? If not let me know & we will tackle it together 🎱

@evanlucas
Copy link

As a general statement, most of the harmony flags should be considered as "in progress". Unless they are enabled by default. A good way to see if something has been shipped would be to run node --v8-options | grep -A1 harmony. If the default shows true, then it should work properly.

@Knighton910
Copy link
Contributor

@pannous did you need anymore help going forward with this?

@subfuzion
Copy link

@pannous, in reference to the bug you mentioned, you could run this command node --v8-options | grep "in progress" to see that "harmony modules" is still in progress.

Please be aware that in progress features are incomplete and possibly broken features of V8, so use them at your own risk. By definition, you should only consider the features that are enabled by default (don't require a runtime flag) to be stable features.

Hope this helps clarify things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants