Require status checks and reviews before PRs can be merged

[zeke]

This is a followup to #55

I think we should enforce a review requirement on this repo using protected branches. We could also use GitHub's CODEOWNERS feature to ensure that the right teams and people are able to review pull requests before they ship.

[RichardLitt]

Sounds good to me. Who can set this up?

[zeke]

I don't have access to the settings tab on this repo.

[bnb]

@zeke I've made both you and @RichardLitt a maintainer after discussing briefly with @obensource 👍

[obensource]

@bnb wahoo! Thanks. @zeke @RichardLitt let your progress be impeded no more. 🙌

[zeke]

Thanks! I still don't seem to have access to repo settings though 🤔

[RichardLitt]

Thanks @bnb! Me neither.

[zeke]

Good day, @bnb! Can you take another peek at this?

[bnb]

@zeke ah my bad - didn't know there was different RBAC for team maintainers and repos, though it totally makes sense. Y'all should have admin rights for this repo (+ @obensource).

[obensource]

Thanks for working that out @bnb 👍

[zeke]

I've enabled branch protection for master. Here's the current configuration:

[zeke]

Going to leave this open so we can discuss it during tomorrow's meeting.

[zeke]

Closing this out. We can revisit when and if we need to change our branch protection setup.