src: hide InitializeICUDirectory symbol #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but couldn't this be a breaking change? |
|
What would be affected by this? It's not usable from an add-on. |
|
Just double checking. |
brendanashworth
added
the
c++
|
@srl295 You want to comment? I'll merge it tomorrow otherwise. |
Exporting it seems like an oversight. It's not safe to call once V8 is running so there doesn't seem to be a point in exporting it to add-ons. Un-export it. PR-URL: nodejs#1815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
bnoordhuis
force-pushed
the
hide-i18n-symbol
branch
from
3ca02fd
to
8c71a92
Compare
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
Exporting it seems like an oversight. It's not safe to call once V8 is running so there doesn't seem to be a point in exporting it to add-ons. Un-export it. PR-URL: nodejs/node#1815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
@bnoordhuis sorry— LGTM in arrears (I was away, just clearing the backlog). Thanks for the catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporting it seems like an oversight. It's not safe to call once
V8 is running so there doesn't seem to be a point in exporting it
to add-ons. Un-export it.
R=@srl295?